From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:35461)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1R9IiR-0004ol-4w
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 11:40:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1R9IiO-0004BY-9r
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 11:40:03 -0400
Received: from mail-bw0-f45.google.com ([209.85.214.45]:46272)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <levinsasha928@gmail.com>) id 1R9IiO-0004BU-1f
	for qemu-devel@nongnu.org; Thu, 29 Sep 2011 11:40:00 -0400
Received: by bkbzv15 with SMTP id zv15so873842bkb.4
	for <qemu-devel@nongnu.org>; Thu, 29 Sep 2011 08:39:59 -0700 (PDT)
From: Sasha Levin <levinsasha928@gmail.com>
In-Reply-To: <4E848CB3.2000608@siemens.com>
References: <1317304660-18072-1-git-send-email-levinsasha928@gmail.com>
	<4E847C56.4020701@siemens.com> <004801cc7eb5$c00c6580$40253080$@de>
	<4E848CB3.2000608@siemens.com>
Content-Type: text/plain; charset="us-ascii"
Date: Thu, 29 Sep 2011 18:39:53 +0300
Message-ID: <1317310793.21918.5.camel@lappy>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] tap: Add optional parameters to up/down
	script
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Thomas Jung <Swoop3r@gmx.de>, 'Anthony Liguori' <aliguori@us.ibm.com>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On Thu, 2011-09-29 at 17:20 +0200, Jan Kiszka wrote:
> On 2011-09-29 16:40, Thomas Jung wrote:
> > On 2011-09-29 16:11 jan kiszka wrote
> >> What kind of parameters would you want to pass? Something that tells VMs
> >> apart (which can be solved without these extensions) or more?
> >>
> >> Jan
> > 
> > In our Case:
> > 
> > We want to simulate an larger environment with multiple switches realized in
> > openvswitch.
> > Openvswitch requires a up- and downscript for each switch. So the idea was,
> > have a single and variable up- and downscript and feed it with parameters
> > (like switch to use, vlan id and so on) through the scriptparams. 
> 
> Sounds reasonable. A short note on the "why" in the description would
> have been nice.

Sure, I'll add the use case to the patch note.

> The patch has some style issues that should be addressed first
> (checkpatch will tell).

I wasn't aware that there was a checkpatch for qemu, now I do :)

I'll fix it and resend.

-- 

Sasha.