From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com,
armbru@redhat.com
Subject: [Qemu-devel] [PATCH 16/26] vl: Change qemu_vmstop_requested() to return a bool
Date: Fri, 30 Sep 2011 17:34:41 -0300 [thread overview]
Message-ID: <1317414891-4042-17-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1317414891-4042-1-git-send-email-lcapitulino@redhat.com>
The stop reason is returned in the RunState argument. This is a
preparation for a future commit which will convert the query-status
command to the QAPI.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
vl.c | 16 ++++++++++------
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/vl.c b/vl.c
index bd4a5ce..4db58bd 100644
--- a/vl.c
+++ b/vl.c
@@ -1350,11 +1350,15 @@ static int qemu_debug_requested(void)
return r;
}
-static RunState qemu_vmstop_requested(void)
+static bool qemu_vmstop_requested(RunState *r)
{
- RunState s = vmstop_requested;
- vmstop_requested = RSTATE_NO_STATE;
- return s;
+ if (vmstop_requested != RSTATE_NO_STATE) {
+ *r = vmstop_requested;
+ vmstop_requested = RSTATE_NO_STATE;
+ return true;
+ }
+
+ return false;
}
void qemu_register_reset(QEMUResetHandler *func, void *opaque)
@@ -1567,7 +1571,7 @@ static void main_loop(void)
#ifdef CONFIG_PROFILER
int64_t ti;
#endif
- int r;
+ RunState r;
qemu_main_loop_start();
@@ -1606,7 +1610,7 @@ static void main_loop(void)
monitor_protocol_event(QEVENT_POWERDOWN, NULL);
qemu_irq_raise(qemu_system_powerdown);
}
- if ((r = qemu_vmstop_requested())) {
+ if (qemu_vmstop_requested(&r)) {
vm_stop(r);
}
}
--
1.7.7.rc0.72.g4b5ea
next prev parent reply other threads:[~2011-09-30 20:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 20:34 [Qemu-devel] [PATCH v2 00/26]: First round of QAPI conversions Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 01/26] error: let error_is_type take a NULL error Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 02/26] qerror: add qerror_report_err() Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 03/26] qapi: add code generation support for middle mode Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 04/26] qapi: use middle mode in QMP server Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 05/26] qapi: fixup command generation for functions that return list types Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 06/26] qapi: dealloc visitor, fix premature free and iteration logic Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 07/26] qapi: generate qapi_free_* functions for *List types Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 08/26] qapi: add test cases for generated free functions Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 09/26] qapi: dealloc visitor, support freeing of nested lists Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 10/26] qapi: modify visitor code generation for list iteration Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 11/26] qapi: Don't use c_var() on enum strings Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 12/26] qapi: Automatically generate a _MAX value for enums Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 13/26] qapi: convert query-name Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 14/26] qapi: Convert query-version Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 15/26] qapi: Convert query-kvm Luiz Capitulino
2011-09-30 20:34 ` Luiz Capitulino [this message]
2011-09-30 20:34 ` [Qemu-devel] [PATCH 17/26] RunState: Drop the RSTATE_NO_STATE value Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 18/26] RunState: Rename enum values as generated by the QAPI Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 19/26] qapi: Convert query-status Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 20/26] qapi: Convert query-uuid Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 21/26] qapi: Convert query-chardev Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 22/26] qapi: Convert query-commands Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 23/26] qapi: Convert quit Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 24/26] qapi: Convert stop Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 25/26] qapi: Convert system_reset Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 26/26] qapi: Convert system_powerdown Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2011-10-05 13:21 [Qemu-devel] [PULL 00/26]: QMP queue Luiz Capitulino
2011-10-05 13:22 ` [Qemu-devel] [PATCH 16/26] vl: Change qemu_vmstop_requested() to return a bool Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317414891-4042-17-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).