qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com,
	armbru@redhat.com
Subject: [Qemu-devel] [PATCH 25/26] qapi: Convert system_reset
Date: Fri, 30 Sep 2011 17:34:50 -0300	[thread overview]
Message-ID: <1317414891-4042-26-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1317414891-4042-1-git-send-email-lcapitulino@redhat.com>

Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 hmp-commands.hx  |    3 +--
 hmp.c            |    5 +++++
 hmp.h            |    1 +
 monitor.c        |   10 ----------
 qapi-schema.json |    9 +++++++++
 qmp-commands.hx  |    5 +----
 qmp.c            |    4 ++++
 7 files changed, 21 insertions(+), 16 deletions(-)

diff --git a/hmp-commands.hx b/hmp-commands.hx
index 3ad1ce7..b2f5cd1 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -477,8 +477,7 @@ ETEXI
         .args_type  = "",
         .params     = "",
         .help       = "reset the system",
-        .user_print = monitor_user_noop,
-        .mhandler.cmd_new = do_system_reset,
+        .mhandler.cmd = hmp_system_reset,
     },
 
 STEXI
diff --git a/hmp.c b/hmp.c
index efcb744..24f30bc 100644
--- a/hmp.c
+++ b/hmp.c
@@ -104,3 +104,8 @@ void hmp_stop(Monitor *mon, const QDict *qdict)
 {
     qmp_stop(NULL);
 }
+
+void hmp_system_reset(Monitor *mon, const QDict *qdict)
+{
+    qmp_system_reset(NULL);
+}
diff --git a/hmp.h b/hmp.h
index cb21cce..a49a6e6 100644
--- a/hmp.h
+++ b/hmp.h
@@ -25,5 +25,6 @@ void hmp_info_uuid(Monitor *mon);
 void hmp_info_chardev(Monitor *mon);
 void hmp_quit(Monitor *mon, const QDict *qdict);
 void hmp_stop(Monitor *mon, const QDict *qdict);
+void hmp_system_reset(Monitor *mon, const QDict *qdict);
 
 #endif
diff --git a/monitor.c b/monitor.c
index e35756b..73c5f01 100644
--- a/monitor.c
+++ b/monitor.c
@@ -1929,16 +1929,6 @@ static void do_boot_set(Monitor *mon, const QDict *qdict)
 }
 
 /**
- * do_system_reset(): Issue a machine reset
- */
-static int do_system_reset(Monitor *mon, const QDict *qdict,
-                           QObject **ret_data)
-{
-    qemu_system_reset_request();
-    return 0;
-}
-
-/**
  * do_system_powerdown(): Issue a machine powerdown
  */
 static int do_system_powerdown(Monitor *mon, const QDict *qdict,
diff --git a/qapi-schema.json b/qapi-schema.json
index cd05034..02de4b5 100644
--- a/qapi-schema.json
+++ b/qapi-schema.json
@@ -248,3 +248,12 @@
 #         state
 ##
 { 'command': 'stop' }
+
+##
+# @system_reset:
+#
+# Performs a hard reset of a guest.
+#
+# Since: 0.14.0
+##
+{ 'command': 'system_reset' }
diff --git a/qmp-commands.hx b/qmp-commands.hx
index 2ccddee..ea96191 100644
--- a/qmp-commands.hx
+++ b/qmp-commands.hx
@@ -223,10 +223,7 @@ EQMP
     {
         .name       = "system_reset",
         .args_type  = "",
-        .params     = "",
-        .help       = "reset the system",
-        .user_print = monitor_user_noop,
-        .mhandler.cmd_new = do_system_reset,
+        .mhandler.cmd_new = qmp_marshal_input_system_reset,
     },
 
 SQMP
diff --git a/qmp.c b/qmp.c
index 6c46479..51d9383 100644
--- a/qmp.c
+++ b/qmp.c
@@ -81,3 +81,7 @@ void qmp_stop(Error **errp)
     vm_stop(RUN_STATE_PAUSED);
 }
 
+void qmp_system_reset(Error **errp)
+{
+    qemu_system_reset_request();
+}
-- 
1.7.7.rc0.72.g4b5ea

  parent reply	other threads:[~2011-09-30 20:35 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-30 20:34 [Qemu-devel] [PATCH v2 00/26]: First round of QAPI conversions Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 01/26] error: let error_is_type take a NULL error Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 02/26] qerror: add qerror_report_err() Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 03/26] qapi: add code generation support for middle mode Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 04/26] qapi: use middle mode in QMP server Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 05/26] qapi: fixup command generation for functions that return list types Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 06/26] qapi: dealloc visitor, fix premature free and iteration logic Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 07/26] qapi: generate qapi_free_* functions for *List types Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 08/26] qapi: add test cases for generated free functions Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 09/26] qapi: dealloc visitor, support freeing of nested lists Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 10/26] qapi: modify visitor code generation for list iteration Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 11/26] qapi: Don't use c_var() on enum strings Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 12/26] qapi: Automatically generate a _MAX value for enums Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 13/26] qapi: convert query-name Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 14/26] qapi: Convert query-version Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 15/26] qapi: Convert query-kvm Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 16/26] vl: Change qemu_vmstop_requested() to return a bool Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 17/26] RunState: Drop the RSTATE_NO_STATE value Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 18/26] RunState: Rename enum values as generated by the QAPI Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 19/26] qapi: Convert query-status Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 20/26] qapi: Convert query-uuid Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 21/26] qapi: Convert query-chardev Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 22/26] qapi: Convert query-commands Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 23/26] qapi: Convert quit Luiz Capitulino
2011-09-30 20:34 ` [Qemu-devel] [PATCH 24/26] qapi: Convert stop Luiz Capitulino
2011-09-30 20:34 ` Luiz Capitulino [this message]
2011-09-30 20:34 ` [Qemu-devel] [PATCH 26/26] qapi: Convert system_powerdown Luiz Capitulino
  -- strict thread matches above, loose matches on Subject: below --
2011-10-05 13:21 [Qemu-devel] [PULL 00/26]: QMP queue Luiz Capitulino
2011-10-05 13:22 ` [Qemu-devel] [PATCH 25/26] qapi: Convert system_reset Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317414891-4042-26-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).