From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAN0k-00077i-Sj for qemu-devel@nongnu.org; Sun, 02 Oct 2011 10:27:24 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RAN0h-0008Dd-2c for qemu-devel@nongnu.org; Sun, 02 Oct 2011 10:27:22 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RAN0f-0008CK-44 for qemu-devel@nongnu.org; Sun, 02 Oct 2011 10:27:17 -0400 From: Avi Kivity Date: Sun, 2 Oct 2011 16:26:55 +0200 Message-Id: <1317565616-12997-25-git-send-email-avi@redhat.com> In-Reply-To: <1317565616-12997-1-git-send-email-avi@redhat.com> References: <1317565616-12997-1-git-send-email-avi@redhat.com> Subject: [Qemu-devel] [PATCH 24/25] milkymist-vgafb: convert to memory API List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Anthony Liguori From: Michael Walle Signed-off-by: Michael Walle Signed-off-by: Avi Kivity --- hw/milkymist-vgafb.c | 33 ++++++++++++++++----------------- 1 files changed, 16 insertions(+), 17 deletions(-) diff --git a/hw/milkymist-vgafb.c b/hw/milkymist-vgafb.c index 2e55e42..be81abd 100644 --- a/hw/milkymist-vgafb.c +++ b/hw/milkymist-vgafb.c @@ -64,6 +64,7 @@ enum { struct MilkymistVgafbState { SysBusDevice busdev; + MemoryRegion regs_region; DisplayState *ds; int invalidate; @@ -153,7 +154,8 @@ static void vgafb_resize(MilkymistVgafbState *s) s->invalidate = 1; } -static uint32_t vgafb_read(void *opaque, target_phys_addr_t addr) +static uint64_t vgafb_read(void *opaque, target_phys_addr_t addr, + unsigned size) { MilkymistVgafbState *s = opaque; uint32_t r = 0; @@ -189,8 +191,8 @@ static uint32_t vgafb_read(void *opaque, target_phys_addr_t addr) return r; } -static void -vgafb_write(void *opaque, target_phys_addr_t addr, uint32_t value) +static void vgafb_write(void *opaque, target_phys_addr_t addr, uint64_t value, + unsigned size) { MilkymistVgafbState *s = opaque; @@ -238,16 +240,14 @@ static uint32_t vgafb_read(void *opaque, target_phys_addr_t addr) } } -static CPUReadMemoryFunc * const vgafb_read_fn[] = { - NULL, - NULL, - &vgafb_read -}; - -static CPUWriteMemoryFunc * const vgafb_write_fn[] = { - NULL, - NULL, - &vgafb_write +static const MemoryRegionOps vgafb_mmio_ops = { + .read = vgafb_read, + .write = vgafb_write, + .valid = { + .min_access_size = 4, + .max_access_size = 4, + }, + .endianness = DEVICE_NATIVE_ENDIAN, }; static void milkymist_vgafb_reset(DeviceState *d) @@ -269,11 +269,10 @@ static void milkymist_vgafb_reset(DeviceState *d) static int milkymist_vgafb_init(SysBusDevice *dev) { MilkymistVgafbState *s = FROM_SYSBUS(typeof(*s), dev); - int vgafb_regs; - vgafb_regs = cpu_register_io_memory(vgafb_read_fn, vgafb_write_fn, s, - DEVICE_NATIVE_ENDIAN); - sysbus_init_mmio(dev, R_MAX * 4, vgafb_regs); + memory_region_init_io(&s->regs_region, &vgafb_mmio_ops, s, + "milkymist-vgafb", R_MAX * 4); + sysbus_init_mmio_region(dev, &s->regs_region); s->ds = graphic_console_init(vgafb_update_display, vgafb_invalidate_display, -- 1.7.6.3