From: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: stefanha@gmail.com, aneesh.kumar@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH 2/2] Use qemu_rwlock_* interface instead of pthread_rwlock_*
Date: Mon, 3 Oct 2011 16:53:14 +0530 [thread overview]
Message-ID: <1317640994-16559-3-git-send-email-harsh@linux.vnet.ibm.com> (raw)
In-Reply-To: <1317640994-16559-1-git-send-email-harsh@linux.vnet.ibm.com>
Signed-off-by: Harsh Prateek Bora <harsh@linux.vnet.ibm.com>
---
hw/9pfs/virtio-9p-synth.c | 23 ++++++++++-------------
1 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/hw/9pfs/virtio-9p-synth.c b/hw/9pfs/virtio-9p-synth.c
index cbf74e4..9867bba 100644
--- a/hw/9pfs/virtio-9p-synth.c
+++ b/hw/9pfs/virtio-9p-synth.c
@@ -30,8 +30,7 @@ V9fsSynthNode v9fs_synth_root = {
.attr = &v9fs_synth_root.actual_attr,
};
-/*FIXME!! should be converted to qemu_rwlock_t */
-static pthread_rwlock_t v9fs_synth_mutex;
+static QemuRWLock v9fs_synth_mutex;
static int v9fs_synth_node_count;
/* set to 1 when the synth fs is ready */
static int v9fs_synth_fs;
@@ -79,7 +78,7 @@ int qemu_v9fs_synth_mkdir(V9fsSynthNode *parent, int mode,
if (!parent) {
parent = &v9fs_synth_root;
}
- pthread_rwlock_wrlock(&v9fs_synth_mutex);
+ qemu_rwlock_wrlock(&v9fs_synth_mutex);
QLIST_FOREACH(tmp, &parent->child, sibling) {
if (!strcmp(tmp->name, name)) {
ret = EEXIST;
@@ -95,7 +94,7 @@ int qemu_v9fs_synth_mkdir(V9fsSynthNode *parent, int mode,
*result = node;
ret = 0;
err_out:
- pthread_rwlock_unlock(&v9fs_synth_mutex);
+ qemu_rwlock_unlock(&v9fs_synth_mutex);
return ret;
}
@@ -116,7 +115,7 @@ int qemu_v9fs_synth_add_file(V9fsSynthNode *parent, int mode,
parent = &v9fs_synth_root;
}
- pthread_rwlock_wrlock(&v9fs_synth_mutex);
+ qemu_rwlock_wrlock(&v9fs_synth_mutex);
QLIST_FOREACH(tmp, &parent->child, sibling) {
if (!strcmp(tmp->name, name)) {
ret = EEXIST;
@@ -137,7 +136,7 @@ int qemu_v9fs_synth_add_file(V9fsSynthNode *parent, int mode,
QLIST_INSERT_HEAD(&parent->child, node, sibling);
ret = 0;
err_out:
- pthread_rwlock_unlock(&v9fs_synth_mutex);
+ qemu_rwlock_unlock(&v9fs_synth_mutex);
return ret;
}
@@ -230,7 +229,7 @@ static int v9fs_synth_get_dentry(V9fsSynthNode *dir, struct dirent *entry,
int i = 0;
V9fsSynthNode *node;
- pthread_rwlock_rdlock(&v9fs_synth_mutex);
+ qemu_rwlock_rdlock(&v9fs_synth_mutex);
QLIST_FOREACH(node, &dir->child, sibling) {
/* This is the off child of the directory */
if (i == off) {
@@ -238,7 +237,7 @@ static int v9fs_synth_get_dentry(V9fsSynthNode *dir, struct dirent *entry,
}
i++;
}
- pthread_rwlock_unlock(&v9fs_synth_mutex);
+ qemu_rwlock_unlock(&v9fs_synth_mutex);
if (!node) {
/* end of directory */
*result = NULL;
@@ -483,13 +482,13 @@ static int v9fs_synth_name_to_path(FsContext *ctx, V9fsPath *dir_path,
goto out;
}
/* search for the name in the childern */
- pthread_rwlock_rdlock(&v9fs_synth_mutex);
+ qemu_rwlock_rdlock(&v9fs_synth_mutex);
QLIST_FOREACH(node, &dir_node->child, sibling) {
if (!strcmp(node->name, name)) {
break;
}
}
- pthread_rwlock_unlock(&v9fs_synth_mutex);
+ qemu_rwlock_unlock(&v9fs_synth_mutex);
if (!node) {
errno = ENOENT;
return -1;
@@ -532,11 +531,9 @@ static ssize_t my_test_read(void *in_buf, int len, off_t offset, void *arg)
static int v9fs_synth_init(FsContext *ctx)
{
V9fsSynthNode *node;
- pthread_rwlockattr_t rwlockattr;
QLIST_INIT(&v9fs_synth_root.child);
- pthread_rwlockattr_init(&rwlockattr);
- pthread_rwlock_init(&v9fs_synth_mutex, &rwlockattr);
+ qemu_rwlock_init(&v9fs_synth_mutex);
/* Add "." and ".." entries for root */
v9fs_add_dir_node(&v9fs_synth_root, v9fs_synth_root.attr->mode,
--
1.7.4.1
next prev parent reply other threads:[~2011-10-03 11:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-03 11:23 [Qemu-devel] [PATCH 0/2] Introduce QemuRWLock Harsh Prateek Bora
2011-10-03 11:23 ` [Qemu-devel] [PATCH 1/2] " Harsh Prateek Bora
2011-10-03 11:23 ` Harsh Prateek Bora [this message]
2011-10-03 12:16 ` [Qemu-devel] [PATCH 0/2] " Jan Kiszka
2011-10-03 17:30 ` Aneesh Kumar K.V
2011-10-03 17:50 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317640994-16559-3-git-send-email-harsh@linux.vnet.ibm.com \
--to=harsh@linux.vnet.ibm.com \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).