qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 0/6] misc vvfat fixes
Date: Wed,  5 Oct 2011 09:12:02 +0200	[thread overview]
Message-ID: <1317798728-28938-1-git-send-email-pbonzini@redhat.com> (raw)

It occurred to me that, if there's one thing vvfat ought to be good
at, it is creating disk images with qemu-img convert (a driver disk
in my case).

It turns out the use case is really broken.  qemu-img doesn't
complete at all, the resulting images often do not pass fsck,
and it's impossible to create a 1.44 MB disk image.  This
series fixes all of the small problems I found.

Coding standard in this file is such a pain that I hardly bothered
about it.


Paolo Bonzini (6):
  vvfat: fix out of bounds array_get usage
  vvfat: do not fail if the disk has spare sectors
  vvfat: need to use first_sectors_number to distinguish fdd/hdd
  vvfat: unify and correct computation of sector count
  vvfat: do not hardcode sector counts in error message
  vvfat: reorganize computation of disk geometry

 block/vvfat.c |   50 ++++++++++++++++++++++++--------------------------
 3 files changed, 26 insertions(+), 28 deletions(-)

-- 
1.7.6

             reply	other threads:[~2011-10-05  7:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  7:12 Paolo Bonzini [this message]
2011-10-05  7:12 ` [Qemu-devel] [PATCH 1/6] vvfat: fix out of bounds array_get usage Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 2/6] vvfat: do not fail if the disk has spare sectors Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 3/6] vvfat: need to use first_sectors_number to distinguish fdd/hdd Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 4/6] vvfat: unify and correct computation of sector count Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 5/6] vvfat: do not hardcode sector counts in error message Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 6/6] vvfat: reorganize computation of disk geometry Paolo Bonzini
2011-11-04 16:21   ` [Qemu-devel] [PATCH 6/6 v2] " Paolo Bonzini
2011-11-04 16:39     ` Kevin Wolf
2011-10-27 11:46 ` [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes Paolo Bonzini
2011-10-27 12:38   ` Kevin Wolf
2011-10-27 13:10     ` Paolo Bonzini
2011-10-27 13:34       ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317798728-28938-1-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).