qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 3/6] vvfat: need to use first_sectors_number to distinguish fdd/hdd
Date: Wed,  5 Oct 2011 09:12:05 +0200	[thread overview]
Message-ID: <1317798728-28938-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1317798728-28938-1-git-send-email-pbonzini@redhat.com>

This is consistent with what "real" floppies have, so file(1)
now actually recognizes the VVFAT image as a 1.44 MB floppy.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 block/vvfat.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index bc2dd4c..eb91642 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -968,7 +968,7 @@ static int init_directories(BDRVVVFATState* s,
     bootsector->number_of_fats=0x2; /* number of FATs */
     bootsector->root_entries=cpu_to_le16(s->sectors_of_root_directory*0x10);
     bootsector->total_sectors16=s->sector_count>0xffff?0:cpu_to_le16(s->sector_count);
-    bootsector->media_type=(s->fat_type!=12?0xf8:s->sector_count==5760?0xf9:0xf8); /* media descriptor */
+    bootsector->media_type=(s->first_sectors_number>1?0xf8:0xf0); /* media descriptor (f8=hd, f0=3.5 fd)*/
     s->fat.pointer[0] = bootsector->media_type;
     bootsector->sectors_per_fat=cpu_to_le16(s->sectors_per_fat);
     bootsector->sectors_per_track=cpu_to_le16(s->bs->secs);
@@ -977,7 +977,7 @@ static int init_directories(BDRVVVFATState* s,
     bootsector->total_sectors=cpu_to_le32(s->sector_count>0xffff?s->sector_count:0);
 
     /* LATER TODO: if FAT32, this is wrong */
-    bootsector->u.fat16.drive_number=s->fat_type==12?0:0x80; /* assume this is hda (TODO) */
+    bootsector->u.fat16.drive_number=s->first_sectors_number==1?0:0x80; /* fda=0, hda=0x80 */
     bootsector->u.fat16.current_head=0;
     bootsector->u.fat16.signature=0x29;
     bootsector->u.fat16.id=cpu_to_le32(0xfabe1afd);
-- 
1.7.6

  parent reply	other threads:[~2011-10-05  7:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-05  7:12 [Qemu-devel] [PATCH 0/6] misc vvfat fixes Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 1/6] vvfat: fix out of bounds array_get usage Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 2/6] vvfat: do not fail if the disk has spare sectors Paolo Bonzini
2011-10-05  7:12 ` Paolo Bonzini [this message]
2011-10-05  7:12 ` [Qemu-devel] [PATCH 4/6] vvfat: unify and correct computation of sector count Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 5/6] vvfat: do not hardcode sector counts in error message Paolo Bonzini
2011-10-05  7:12 ` [Qemu-devel] [PATCH 6/6] vvfat: reorganize computation of disk geometry Paolo Bonzini
2011-11-04 16:21   ` [Qemu-devel] [PATCH 6/6 v2] " Paolo Bonzini
2011-11-04 16:39     ` Kevin Wolf
2011-10-27 11:46 ` [Qemu-devel] ping Re: [PATCH 0/6] misc vvfat fixes Paolo Bonzini
2011-10-27 12:38   ` Kevin Wolf
2011-10-27 13:10     ` Paolo Bonzini
2011-10-27 13:34       ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1317798728-28938-4-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).