From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBLjo-0007FH-UY for qemu-devel@nongnu.org; Wed, 05 Oct 2011 03:18:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBLjn-0006Fg-Ad for qemu-devel@nongnu.org; Wed, 05 Oct 2011 03:17:56 -0400 Received: from mail-wy0-f173.google.com ([74.125.82.173]:35870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBLjn-0006EY-4Y for qemu-devel@nongnu.org; Wed, 05 Oct 2011 03:17:55 -0400 Received: by mail-wy0-f173.google.com with SMTP id 22so1507475wyh.4 for ; Wed, 05 Oct 2011 00:17:54 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 5 Oct 2011 09:17:36 +0200 Message-Id: <1317799065-29668-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1317799065-29668-1-git-send-email-pbonzini@redhat.com> References: <1317799065-29668-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v3 06/15] block: group together the plugging of synchronous IO emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is duplicated twice for read/write operations. Unify it, and move it close to the code that adds bdrv_flush. Signed-off-by: Paolo Bonzini --- block.c | 16 ++++++++-------- 1 files changed, 8 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index ce35dce..394ecaf 100644 --- a/block.c +++ b/block.c @@ -189,26 +189,26 @@ void bdrv_register(BlockDriver *bdrv) /* Emulate AIO by coroutines, and sync by AIO */ bdrv->bdrv_aio_readv = bdrv_co_aio_readv_em; bdrv->bdrv_aio_writev = bdrv_co_aio_writev_em; - bdrv->bdrv_read = bdrv_read_em; - bdrv->bdrv_write = bdrv_write_em; } else { bdrv->bdrv_co_readv = bdrv_co_readv_em; bdrv->bdrv_co_writev = bdrv_co_writev_em; - if (!bdrv->bdrv_aio_readv) { /* add AIO emulation layer */ bdrv->bdrv_aio_readv = bdrv_aio_readv_em; bdrv->bdrv_aio_writev = bdrv_aio_writev_em; - } else if (!bdrv->bdrv_read) { - /* add synchronous IO emulation layer */ - bdrv->bdrv_read = bdrv_read_em; - bdrv->bdrv_write = bdrv_write_em; } } if (!bdrv->bdrv_aio_flush) { bdrv->bdrv_aio_flush = bdrv_aio_flush_em; - } else if (!bdrv->bdrv_flush) { + } + + /* add synchronous IO emulation layer */ + if (!bdrv->bdrv_read) { + bdrv->bdrv_read = bdrv_read_em; + bdrv->bdrv_write = bdrv_write_em; + } + if (!bdrv->bdrv_flush) { bdrv->bdrv_flush = bdrv_flush_em; } -- 1.7.6