From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44398) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RBixo-0002h1-57 for qemu-devel@nongnu.org; Thu, 06 Oct 2011 04:06:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RBixT-0000yr-P4 for qemu-devel@nongnu.org; Thu, 06 Oct 2011 04:05:55 -0400 From: Alexander Graf Date: Thu, 6 Oct 2011 10:05:51 +0200 Message-Id: <1317888366-10509-50-git-send-email-agraf@suse.de> In-Reply-To: <1317888366-10509-1-git-send-email-agraf@suse.de> References: <1317888366-10509-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 49/64] vscsi: send the CHECK_CONDITION status down together with autosense data List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Paolo Bonzini , qemu-ppc@nongnu.org From: Paolo Bonzini I introduced this bug in commit 05751d3 (vscsi: always use get_sense, 2011-08-03) because at the time there was no way to expose a sense condition to SLOF and Linux manages to work around the bug. However, the bug becomes evident now that SCSI devices also report unit attention on reset. SLOF also has problems dealing with unit attention conditions, so it still will not boot even with this fix (just like OpenBIOS). IBM folks are aware of their part of the bug. :-) Reported-by: Thomas Huth Signed-off-by: Paolo Bonzini Acked-by: David Gibson Signed-off-by: Alexander Graf --- hw/spapr_vscsi.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/hw/spapr_vscsi.c b/hw/spapr_vscsi.c index 6fc82f6..e8426d7 100644 --- a/hw/spapr_vscsi.c +++ b/hw/spapr_vscsi.c @@ -483,7 +483,6 @@ static void vscsi_command_complete(SCSIRequest *sreq, uint32_t status) if (status == CHECK_CONDITION) { req->senselen = scsi_req_get_sense(req->sreq, req->sense, sizeof(req->sense)); - status = 0; dprintf("VSCSI: Sense data, %d bytes:\n", len); dprintf(" %02x %02x %02x %02x %02x %02x %02x %02x\n", req->sense[0], req->sense[1], req->sense[2], req->sense[3], -- 1.6.0.2