From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 12/25] memory: Fix old portio word accesses
Date: Thu, 6 Oct 2011 12:23:22 +0200 [thread overview]
Message-ID: <1317896615-25202-13-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1317896615-25202-1-git-send-email-avi@redhat.com>
From: Jan Kiszka <jan.kiszka@siemens.com>
As we register old portio regions via ioport_register, we are also
responsible for providing the word access wrapper.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
memory.c | 10 ++++++++++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/memory.c b/memory.c
index 528e5fb..a8359b1 100644
--- a/memory.c
+++ b/memory.c
@@ -404,6 +404,11 @@ static void memory_region_iorange_read(IORange *iorange,
*data = ((uint64_t)1 << (width * 8)) - 1;
if (mrp) {
*data = mrp->read(mr->opaque, offset + mr->offset);
+ } else if (width == 2) {
+ mrp = find_portio(mr, offset, 1, false);
+ assert(mrp);
+ *data = mrp->read(mr->opaque, offset + mr->offset) |
+ (mrp->read(mr->opaque, offset + mr->offset + 1) << 8);
}
return;
}
@@ -426,6 +431,11 @@ static void memory_region_iorange_write(IORange *iorange,
if (mrp) {
mrp->write(mr->opaque, offset + mr->offset, data);
+ } else if (width == 2) {
+ mrp = find_portio(mr, offset, 1, false);
+ assert(mrp);
+ mrp->write(mr->opaque, offset + mr->offset, data & 0xff);
+ mrp->write(mr->opaque, offset + mr->offset + 1, data >> 8);
}
return;
}
--
1.7.6.3
next prev parent reply other threads:[~2011-10-06 10:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 10:23 [Qemu-devel] [PATCH 00/25] Memory API converions, batch 11 Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 01/25] hw/lan9118.c: Convert to MemoryRegion Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 02/25] PPC: Fix via-cuda memory registration Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 03/25] palm: convert to memory API Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 04/25] petalogix_ml605: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 05/25] petalogix_s2adsp1800: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 06/25] ppc405_boards: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 07/25] hw/arm11mpcore: Clean up to avoid using sysbus_mmio_init_cb2 Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 08/25] hw/versatile_pci: Expose multiple sysbus mmio regions Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 09/25] ppc_newworld: convert to memory API Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 10/25] isa: Tidy support code for isabus_get_fw_dev_path Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 11/25] Introduce PortioList Avi Kivity
2011-10-06 10:23 ` Avi Kivity [this message]
2011-10-06 10:23 ` [Qemu-devel] [PATCH 13/25] isa: Add isa_register_portio_list() Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 14/25] fdc: Convert to isa_register_portio_list Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 15/25] gus: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 16/25] m48t59: Convert to isa_register_ioport Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 17/25] rtc: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 18/25] ne2000: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 19/25] parallel: Convert to isa_register_portio_list Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 20/25] sb16: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 21/25] vga: " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 22/25] pc: Convert port92 to isa_register_ioport Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 23/25] vmport: Convert " Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 24/25] ide: Convert to isa_register_portio_list Avi Kivity
2011-10-06 10:23 ` [Qemu-devel] [PATCH 25/25] isa: Remove isa_init_ioport_range and isa_init_ioport Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317896615-25202-13-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).