From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:42580) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RC6H8-0007sz-W4 for qemu-devel@nongnu.org; Fri, 07 Oct 2011 04:59:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RC6H8-0005iS-2v for qemu-devel@nongnu.org; Fri, 07 Oct 2011 04:59:26 -0400 Received: from mail-bw0-f45.google.com ([209.85.214.45]:43740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RC6H7-0005hM-Lm for qemu-devel@nongnu.org; Fri, 07 Oct 2011 04:59:25 -0400 Received: by mail-bw0-f45.google.com with SMTP id zv15so4509282bkb.4 for ; Fri, 07 Oct 2011 01:59:25 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 7 Oct 2011 10:59:14 +0200 Message-Id: <1317977954-21366-5-git-send-email-pbonzini@redhat.com> In-Reply-To: <1317977954-21366-1-git-send-email-pbonzini@redhat.com> References: <1317977954-21366-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 4/4] scsi-disk: fix retrying a flush List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Flush does not go anymore through scsi_disk_emulate_command. Signed-off-by: Paolo Bonzini --- hw/scsi-disk.c | 9 +++------ 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index d6f2345..eb0c679 100644 --- a/hw/scsi-disk.c +++ b/hw/scsi-disk.c @@ -81,7 +81,7 @@ struct SCSIDiskState }; static int scsi_handle_rw_error(SCSIDiskReq *r, int error, int type); -static int scsi_disk_emulate_command(SCSIDiskReq *r); +static int32_t scsi_send_command(SCSIRequest *req, uint8_t *buf); static void scsi_free_request(SCSIRequest *req) { @@ -335,7 +335,6 @@ static void scsi_dma_restart_bh(void *opaque) r = DO_UPCAST(SCSIDiskReq, req, req); if (r->status & SCSI_REQ_STATUS_RETRY) { int status = r->status; - int ret; r->status &= ~(SCSI_REQ_STATUS_RETRY | SCSI_REQ_STATUS_RETRY_TYPE_MASK); @@ -348,10 +347,8 @@ static void scsi_dma_restart_bh(void *opaque) scsi_write_data(&r->req); break; case SCSI_REQ_STATUS_RETRY_FLUSH: - ret = scsi_disk_emulate_command(r); - if (ret == 0) { - scsi_req_complete(&r->req, GOOD); - } + scsi_send_command(&r->req, r->req.cmd.buf); + break; } /* This reference was left in by scsi_handle_rw_error. */ scsi_req_unref(&r->req); -- 1.7.6