From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCAxI-0000l7-O6 for qemu-devel@nongnu.org; Fri, 07 Oct 2011 09:59:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RCAxB-00080u-DX for qemu-devel@nongnu.org; Fri, 07 Oct 2011 09:59:16 -0400 Received: from mail-ey0-f173.google.com ([209.85.215.173]:54280) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RCAxB-00080g-2h for qemu-devel@nongnu.org; Fri, 07 Oct 2011 09:59:09 -0400 Received: by eye4 with SMTP id 4so1343797eye.4 for ; Fri, 07 Oct 2011 06:59:08 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 7 Oct 2011 15:59:01 +0200 Message-Id: <1317995941-26266-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH] checkpatch: remove rule on non-indented labels List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org There are 508 non-indented (non-default) labels, and 511 that are indented. So the rule is debatable at least. Actually, in the common case of labels at the outermost scope, there is really just one place where to put the label, so the rule is just wrong IMHO. Signed-off-by: Paolo Bonzini --- scripts/checkpatch.pl | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 0eba357..7a71324 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -2206,12 +2206,6 @@ sub process { ERROR("space prohibited before that close parenthesis ')'\n" . $herecurr); } -#goto labels aren't indented, allow a single space however - if ($line=~/^.\s+[A-Za-z\d_]+:(?![0-9]+)/ and - !($line=~/^. [A-Za-z\d_]+:/) and !($line=~/^.\s+default:/)) { - WARN("labels should not be indented\n" . $herecurr); - } - # Return is not a function. if (defined($stat) && $stat =~ /^.\s*return(\s*)(\(.*);/s) { my $spacing = $1; -- 1.7.6