* [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close()
@ 2011-10-10 12:52 Andreas Färber
2011-10-20 14:18 ` Andreas Färber
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2011-10-10 12:52 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Andreas Färber
env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free().
Cc: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
target-arm/helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index d3a3ba2..8195c56 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -471,7 +471,7 @@ static uint32_t cpu_arm_find_by_name(const char *name)
void cpu_arm_close(CPUARMState *env)
{
- free(env);
+ g_free(env);
}
uint32_t cpsr_read(CPUARMState *env)
--
1.7.6.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close()
2011-10-10 12:52 [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close() Andreas Färber
@ 2011-10-20 14:18 ` Andreas Färber
2011-10-20 14:27 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Andreas Färber @ 2011-10-20 14:18 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel
Am 10.10.2011 14:52, schrieb Andreas Färber:
> env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free().
>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> target-arm/helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index d3a3ba2..8195c56 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -471,7 +471,7 @@ static uint32_t cpu_arm_find_by_name(const char *name)
>
> void cpu_arm_close(CPUARMState *env)
> {
> - free(env);
> + g_free(env);
> }
>
> uint32_t cpsr_read(CPUARMState *env)
Ping! Didn't see this in the pull request... Should it go through
qemu-trivial instead?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746, AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close()
2011-10-20 14:18 ` Andreas Färber
@ 2011-10-20 14:27 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2011-10-20 14:27 UTC (permalink / raw)
To: Andreas Färber; +Cc: qemu-devel
On 20 October 2011 15:18, Andreas Färber <afaerber@suse.de> wrote:
> Am 10.10.2011 14:52, schrieb Andreas Färber:
>> env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free().
>>
>> Cc: Peter Maydell <peter.maydell@linaro.org>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> ---
>> target-arm/helper.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/target-arm/helper.c b/target-arm/helper.c
>> index d3a3ba2..8195c56 100644
>> --- a/target-arm/helper.c
>> +++ b/target-arm/helper.c
>> @@ -471,7 +471,7 @@ static uint32_t cpu_arm_find_by_name(const char *name)
>>
>> void cpu_arm_close(CPUARMState *env)
>> {
>> - free(env);
>> + g_free(env);
>> }
>>
>> uint32_t cpsr_read(CPUARMState *env)
>
> Ping! Didn't see this in the pull request... Should it go through
> qemu-trivial instead?
Rats, missed that one. I guess I'd better redo the pullreq.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-20 14:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-10 12:52 [Qemu-devel] [PATCH] target-arm: Fix use of free() in cpu_arm_close() Andreas Färber
2011-10-20 14:18 ` Andreas Färber
2011-10-20 14:27 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).