From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 06/24] hw/arm11mpcore: Clean up to avoid using sysbus_mmio_init_cb2
Date: Mon, 10 Oct 2011 16:59:35 +0200 [thread overview]
Message-ID: <1318258793-10576-7-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1318258793-10576-1-git-send-email-avi@redhat.com>
From: Peter Maydell <peter.maydell@linaro.org>
Clean up the initialisation of the realview_mpcore device to avoid
using sysbus_init_mmio_cb2(): we can pass through the MemoryRegion
of the private arm11mpcore_priv device directly now.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/arm11mpcore.c | 13 +------------
1 files changed, 1 insertions(+), 12 deletions(-)
diff --git a/hw/arm11mpcore.c b/hw/arm11mpcore.c
index 7d60ef6..974a0d8 100644
--- a/hw/arm11mpcore.c
+++ b/hw/arm11mpcore.c
@@ -48,17 +48,6 @@ static void mpcore_rirq_set_irq(void *opaque, int irq, int level)
}
}
-static void mpcore_rirq_map(SysBusDevice *dev, target_phys_addr_t base)
-{
- mpcore_rirq_state *s = FROM_SYSBUS(mpcore_rirq_state, dev);
- sysbus_mmio_map(s->priv, 0, base);
-}
-
-static void mpcore_rirq_unmap(SysBusDevice *dev, target_phys_addr_t base)
-{
- /* nothing to do */
-}
-
static int realview_mpcore_init(SysBusDevice *dev)
{
mpcore_rirq_state *s = FROM_SYSBUS(mpcore_rirq_state, dev);
@@ -84,7 +73,7 @@ static int realview_mpcore_init(SysBusDevice *dev)
}
}
qdev_init_gpio_in(&dev->qdev, mpcore_rirq_set_irq, 64);
- sysbus_init_mmio_cb2(dev, mpcore_rirq_map, mpcore_rirq_unmap);
+ sysbus_init_mmio_region(dev, sysbus_mmio_get_region(s->priv, 0));
return 0;
}
--
1.7.6.3
next prev parent reply other threads:[~2011-10-10 15:00 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 14:59 [Qemu-devel] [PULL 00/24] Memory API, batch 11 Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 01/24] hw/lan9118.c: Convert to MemoryRegion Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 02/24] palm: convert to memory API Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 03/24] petalogix_ml605: " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 04/24] petalogix_s2adsp1800: " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 05/24] ppc405_boards: " Avi Kivity
2011-10-10 14:59 ` Avi Kivity [this message]
2011-10-10 14:59 ` [Qemu-devel] [PATCH 07/24] hw/versatile_pci: Expose multiple sysbus mmio regions Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 08/24] ppc_newworld: convert to memory API Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 09/24] isa: Tidy support code for isabus_get_fw_dev_path Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 10/24] Introduce PortioList Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 11/24] memory: Fix old portio word accesses Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 12/24] isa: Add isa_register_portio_list() Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 13/24] fdc: Convert to isa_register_portio_list Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 14/24] gus: " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 15/24] m48t59: Convert to isa_register_ioport Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 16/24] rtc: " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 17/24] ne2000: " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 18/24] parallel: Convert to isa_register_portio_list Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 19/24] sb16: " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 20/24] vga: " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 21/24] pc: Convert port92 to isa_register_ioport Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 22/24] vmport: Convert " Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 23/24] ide: Convert to isa_register_portio_list Avi Kivity
2011-10-10 14:59 ` [Qemu-devel] [PATCH 24/24] isa: Remove isa_init_ioport_range and isa_init_ioport Avi Kivity
2011-10-11 13:25 ` [Qemu-devel] [PULL 00/24] Memory API, batch 11 Anthony Liguori
2011-10-11 13:51 ` Avi Kivity
2011-10-11 13:58 ` Avi Kivity
2011-10-14 16:25 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318258793-10576-7-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).