qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 02/10] scsi-generic: remove scsi_req_fixup
Date: Wed, 12 Oct 2011 16:24:03 +0200	[thread overview]
Message-ID: <1318429451-9306-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1318429451-9306-1-git-send-email-pbonzini@redhat.com>

This is not needed anymore, since asynchronous ioctls were introduced
by commit 221f715 (new scsi-generic abstraction, use SG_IO, 2009-03-28).

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 hw/scsi-generic.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 1e5c41b..5130e9a 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -233,19 +233,6 @@ static uint8_t *scsi_get_buf(SCSIRequest *req)
     return r->buf;
 }
 
-static void scsi_req_fixup(SCSIRequest *req)
-{
-    switch(req->cmd.buf[0]) {
-    case REWIND:
-    case START_STOP:
-        if (req->dev->type == TYPE_TAPE) {
-            /* force IMMED, otherwise qemu waits end of command */
-            req->cmd.buf[1] = 0x01;
-        }
-        break;
-    }
-}
-
 /* Execute a scsi command.  Returns the length of the data expected by the
    command.  This will be Positive for data transfers from the device
    (eg. disk reads), negative for transfers to the device (eg. disk writes),
@@ -257,8 +244,6 @@ static int32_t scsi_send_command(SCSIRequest *req, uint8_t *cmd)
     SCSIDevice *s = r->req.dev;
     int ret;
 
-    scsi_req_fixup(&r->req);
-
     DPRINTF("Command: lun=%d tag=0x%x len %zd data=0x%02x", lun, tag,
             r->req.cmd.xfer, cmd[0]);
 
-- 
1.7.6

  parent reply	other threads:[~2011-10-12 14:24 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-12 14:24 [Qemu-devel] [PATCH 00/10] scsi: add specialized block device passthrough Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 01/10] scsi-generic: drop SCSIGenericState Paolo Bonzini
2011-10-12 14:24 ` Paolo Bonzini [this message]
2011-10-12 14:24 ` [Qemu-devel] [PATCH 03/10] scsi-generic: check ioctl statuses when SG_IO succeeds Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 04/10] scsi-generic: look at host status Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 05/10] scsi-disk: do not duplicate BlockDriverState member Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 06/10] scsi-disk: small clean up to INQUIRY Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 07/10] scsi: make reqops const Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 08/10] scsi: export scsi_generic_reqops Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 09/10] scsi: pass cdb to alloc_req Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 10/10] scsi-disk: add scsi-block for device passthrough Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318429451-9306-3-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).