From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 03/10] scsi-generic: check ioctl statuses when SG_IO succeeds
Date: Wed, 12 Oct 2011 16:24:04 +0200 [thread overview]
Message-ID: <1318429451-9306-4-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1318429451-9306-1-git-send-email-pbonzini@redhat.com>
A succeeding ioctl does not imply that the SCSI command succeeded.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi-generic.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 5130e9a..04549aa 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -311,7 +311,7 @@ static int get_blocksize(BlockDriverState *bdrv)
io_header.timeout = 6000; /* XXX */
ret = bdrv_ioctl(bdrv, SG_IO, &io_header);
- if (ret < 0)
+ if (ret < 0 || io_header.driver_status || io_header.host_status)
return -1;
return ldl_be_p(&buf[4]);
@@ -341,7 +341,7 @@ static int get_stream_blocksize(BlockDriverState *bdrv)
io_header.timeout = 6000; /* XXX */
ret = bdrv_ioctl(bdrv, SG_IO, &io_header);
- if (ret < 0)
+ if (ret < 0 || io_header.driver_status || io_header.host_status)
return -1;
return ldl_be_p(&buf[0]) & 0xffffff;
--
1.7.6
next prev parent reply other threads:[~2011-10-12 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 14:24 [Qemu-devel] [PATCH 00/10] scsi: add specialized block device passthrough Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 01/10] scsi-generic: drop SCSIGenericState Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 02/10] scsi-generic: remove scsi_req_fixup Paolo Bonzini
2011-10-12 14:24 ` Paolo Bonzini [this message]
2011-10-12 14:24 ` [Qemu-devel] [PATCH 04/10] scsi-generic: look at host status Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 05/10] scsi-disk: do not duplicate BlockDriverState member Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 06/10] scsi-disk: small clean up to INQUIRY Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 07/10] scsi: make reqops const Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 08/10] scsi: export scsi_generic_reqops Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 09/10] scsi: pass cdb to alloc_req Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 10/10] scsi-disk: add scsi-block for device passthrough Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318429451-9306-4-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).