From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 04/10] scsi-generic: look at host status
Date: Wed, 12 Oct 2011 16:24:05 +0200 [thread overview]
Message-ID: <1318429451-9306-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1318429451-9306-1-git-send-email-pbonzini@redhat.com>
Pass down the host status so that failing transport can be detected
by the guest. Similar treatment of host status could be done in
virtio-blk, too.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
hw/scsi-generic.c | 20 ++++++++++++++++----
1 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 04549aa..7b291ec 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -39,8 +39,13 @@ do { fprintf(stderr, "scsi-generic: " fmt , ## __VA_ARGS__); } while (0)
#define SCSI_SENSE_BUF_SIZE 96
-#define SG_ERR_DRIVER_TIMEOUT 0x06
-#define SG_ERR_DRIVER_SENSE 0x08
+#define SG_ERR_DRIVER_TIMEOUT 0x06
+#define SG_ERR_DRIVER_SENSE 0x08
+
+#define SG_ERR_DID_OK 0x00
+#define SG_ERR_DID_NO_CONNECT 0x01
+#define SG_ERR_DID_BUS_BUSY 0x02
+#define SG_ERR_DID_TIME_OUT 0x03
#ifndef MAX_UINT
#define MAX_UINT ((unsigned int)-1)
@@ -68,8 +73,9 @@ static void scsi_command_complete(void *opaque, int ret)
SCSIGenericReq *r = (SCSIGenericReq *)opaque;
r->req.aiocb = NULL;
- if (r->io_header.driver_status & SG_ERR_DRIVER_SENSE)
+ if (r->io_header.driver_status & SG_ERR_DRIVER_SENSE) {
r->req.sense_len = r->io_header.sb_len_wr;
+ }
if (ret != 0) {
switch (ret) {
@@ -86,9 +92,15 @@ static void scsi_command_complete(void *opaque, int ret)
break;
}
} else {
- if (r->io_header.driver_status & SG_ERR_DRIVER_TIMEOUT) {
+ if (r->io_header.host_status == SG_ERR_DID_NO_CONNECT ||
+ r->io_header.host_status == SG_ERR_DID_BUS_BUSY ||
+ r->io_header.host_status == SG_ERR_DID_TIME_OUT ||
+ (r->io_header.driver_status & SG_ERR_DRIVER_TIMEOUT)) {
status = BUSY;
BADF("Driver Timeout\n");
+ } else if (r->io_header.host_status) {
+ status = CHECK_CONDITION;
+ scsi_req_build_sense(&r->req, SENSE_CODE(I_T_NEXUS_LOSS));
} else if (r->io_header.status) {
status = r->io_header.status;
} else if (r->io_header.driver_status & SG_ERR_DRIVER_SENSE) {
--
1.7.6
next prev parent reply other threads:[~2011-10-12 14:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-12 14:24 [Qemu-devel] [PATCH 00/10] scsi: add specialized block device passthrough Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 01/10] scsi-generic: drop SCSIGenericState Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 02/10] scsi-generic: remove scsi_req_fixup Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 03/10] scsi-generic: check ioctl statuses when SG_IO succeeds Paolo Bonzini
2011-10-12 14:24 ` Paolo Bonzini [this message]
2011-10-12 14:24 ` [Qemu-devel] [PATCH 05/10] scsi-disk: do not duplicate BlockDriverState member Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 06/10] scsi-disk: small clean up to INQUIRY Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 07/10] scsi: make reqops const Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 08/10] scsi: export scsi_generic_reqops Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 09/10] scsi: pass cdb to alloc_req Paolo Bonzini
2011-10-12 14:24 ` [Qemu-devel] [PATCH 10/10] scsi-disk: add scsi-block for device passthrough Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318429451-9306-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).