From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:57716) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REPLr-0004Dp-Px for qemu-devel@nongnu.org; Thu, 13 Oct 2011 13:45:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1REPLn-0004Ts-6a for qemu-devel@nongnu.org; Thu, 13 Oct 2011 13:45:51 -0400 Received: from mnementh.archaic.org.uk ([81.2.115.146]:41765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1REPLm-0004TM-Ss for qemu-devel@nongnu.org; Thu, 13 Oct 2011 13:45:47 -0400 From: Peter Maydell Date: Thu, 13 Oct 2011 18:45:37 +0100 Message-Id: <1318527937-22450-1-git-send-email-peter.maydell@linaro.org> Subject: [Qemu-devel] [PATCH] compatfd.c: Don't pass NULL pointer to SYS_signalfd List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: patches@linaro.org Don't pass a NULL pointer in to SYS_signalfd in qemu_signalfd_available(): this isn't valid and Valgrind complains about it. Signed-off-by: Peter Maydell --- compatfd.c | 12 ++++++++++-- 1 files changed, 10 insertions(+), 2 deletions(-) diff --git a/compatfd.c b/compatfd.c index 31654c6..02306a4 100644 --- a/compatfd.c +++ b/compatfd.c @@ -119,9 +119,17 @@ int qemu_signalfd(const sigset_t *mask) bool qemu_signalfd_available(void) { #ifdef CONFIG_SIGNALFD + sigset_t mask; + int fd; + bool ok; + sigemptyset(&mask); errno = 0; - syscall(SYS_signalfd, -1, NULL, _NSIG / 8); - return errno != ENOSYS; + fd = syscall(SYS_signalfd, -1, &mask, _NSIG / 8); + ok = (errno != ENOSYS); + if (fd >= 0) { + close(fd); + } + return ok; #else return false; #endif -- 1.7.1