From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46233) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGDIY-0005l3-VJ for qemu-devel@nongnu.org; Tue, 18 Oct 2011 13:17:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGDIT-0007H0-Dy for qemu-devel@nongnu.org; Tue, 18 Oct 2011 13:17:54 -0400 From: Pavel Borzenkov Date: Tue, 18 Oct 2011 21:17:35 +0400 Message-Id: <1318958255-14008-1-git-send-email-pavel.borzenkov@gmail.com> Subject: [Qemu-devel] [PATCH] qed: don't pass NULL to memcpy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- block/qed.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/block/qed.c b/block/qed.c index c3e45af..e6720db 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1424,8 +1424,10 @@ static int bdrv_qed_change_backing_file(BlockDriverState *bs, memcpy(buffer, &le_header, sizeof(le_header)); buffer_len = sizeof(le_header); - memcpy(buffer + buffer_len, backing_file, backing_file_len); - buffer_len += backing_file_len; + if (backing_file) { + memcpy(buffer + buffer_len, backing_file, backing_file_len); + buffer_len += backing_file_len; + } /* Write new header */ ret = bdrv_pwrite_sync(bs->file, 0, buffer, buffer_len); -- 1.7.0.4