* [Qemu-devel] [PATCH] qed: remove unneeded variable assignment
@ 2011-10-18 17:17 Pavel Borzenkov
2011-10-20 17:23 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Borzenkov @ 2011-10-18 17:17 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
'ret' is unconditionally overwitten by qed_read_l1_table_sync()
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
---
block/qed.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index e87dc4d..c3e45af 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -388,7 +388,6 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
if (ret < 0) {
return ret;
}
- ret = 0; /* ret should always be 0 or -errno */
qed_header_le_to_cpu(&le_header, &s->header);
if (s->header.magic != QED_MAGIC) {
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] qed: remove unneeded variable assignment
2011-10-18 17:17 [Qemu-devel] [PATCH] qed: remove unneeded variable assignment Pavel Borzenkov
@ 2011-10-20 17:23 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2011-10-20 17:23 UTC (permalink / raw)
To: Pavel Borzenkov; +Cc: qemu-trivial, qemu-devel
On Tue, Oct 18, 2011 at 09:17:56PM +0400, Pavel Borzenkov wrote:
> 'ret' is unconditionally overwitten by qed_read_l1_table_sync()
>
> Spotted by Clang Analyzer
>
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
> ---
> block/qed.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-20 17:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 17:17 [Qemu-devel] [PATCH] qed: remove unneeded variable assignment Pavel Borzenkov
2011-10-20 17:23 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).