From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46300) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RGDIs-0006Q9-QQ for qemu-devel@nongnu.org; Tue, 18 Oct 2011 13:18:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RGDIo-0007LG-J0 for qemu-devel@nongnu.org; Tue, 18 Oct 2011 13:18:14 -0400 From: Pavel Borzenkov Date: Tue, 18 Oct 2011 21:17:56 +0400 Message-Id: <1318958276-14049-1-git-send-email-pavel.borzenkov@gmail.com> Subject: [Qemu-devel] [PATCH] qed: remove unneeded variable assignment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org 'ret' is unconditionally overwitten by qed_read_l1_table_sync() Spotted by Clang Analyzer Signed-off-by: Pavel Borzenkov --- block/qed.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/block/qed.c b/block/qed.c index e87dc4d..c3e45af 100644 --- a/block/qed.c +++ b/block/qed.c @@ -388,7 +388,6 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags) if (ret < 0) { return ret; } - ret = 0; /* ret should always be 0 or -errno */ qed_header_le_to_cpu(&le_header, &s->header); if (s->header.magic != QED_MAGIC) { -- 1.7.0.4