* [Qemu-devel] [PATCH] vmdk: vmdk_read_cid returns garbage if p_name is NULL
@ 2011-10-18 17:19 Pavel Borzenkov
2011-10-20 17:22 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 1 reply; 2+ messages in thread
From: Pavel Borzenkov @ 2011-10-18 17:19 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Spotted by Clang Analyzer
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
---
block/vmdk.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 3969131..a75dcc2 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -207,7 +207,7 @@ static void vmdk_free_last_extent(BlockDriverState *bs)
static uint32_t vmdk_read_cid(BlockDriverState *bs, int parent)
{
char desc[DESC_SIZE];
- uint32_t cid;
+ uint32_t cid = 0xffffffff;
const char *p_name, *cid_str;
size_t cid_str_size;
BDRVVmdkState *s = bs->opaque;
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: vmdk_read_cid returns garbage if p_name is NULL
2011-10-18 17:19 [Qemu-devel] [PATCH] vmdk: vmdk_read_cid returns garbage if p_name is NULL Pavel Borzenkov
@ 2011-10-20 17:22 ` Stefan Hajnoczi
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Hajnoczi @ 2011-10-20 17:22 UTC (permalink / raw)
To: Pavel Borzenkov; +Cc: qemu-trivial, qemu-devel
On Tue, Oct 18, 2011 at 09:19:03PM +0400, Pavel Borzenkov wrote:
> Spotted by Clang Analyzer
>
> Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
> ---
> block/vmdk.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the trivial patches tree:
http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-20 17:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-18 17:19 [Qemu-devel] [PATCH] vmdk: vmdk_read_cid returns garbage if p_name is NULL Pavel Borzenkov
2011-10-20 17:22 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).