[Qemu-devel] [PULL v2 0/8] target-arm queue

[Qemu-devel] [PULL v2 0/8] target-arm queue

[Peter Maydell]

Hi; these are the pending target-arm patches I'd like to get in for 1.0;
a couple of minor ones plus the A15 insn work. Please pull.

V2 of this pullreq just adds Andreas' trivial patch as 8/8,
so I haven't bothered re-emailing the identical 1-7, just this
cover letter and 8/8.

-- PMM

The following changes since commit cfce6d8934243871c4dc6d0c5248b0b27a1b8d80:

  i8259: Move to hw library (2011-10-16 11:11:56 +0000)

are available in the git repository at:
  git://git.linaro.org/people/pmaydell/qemu-arm.git target-arm.for-upstream

Andreas Färber (1):
      target-arm: Fix use of free() in cpu_arm_close()

Christophe LYON (1):
      rsqrte_f32: No need to copy sign bit.

Dmitry Koshelev (1):
      target-arm/machine.c: Restore VFP registers correctly

Peter Maydell (5):
      target-arm: v6 media multiply space: UNDEF on unassigned encodings
      target-arm: Rename ARM_FEATURE_DIV to _THUMB_DIV
      target-arm: Add ARM UDIV/SDIV support
      softfloat: Implement fused multiply-add
      target-arm: Implement VFPv4 fused multiply-accumulate insns

 fpu/softfloat-specialize.h |  178 ++++++++++++++++++
 fpu/softfloat.c            |  427 ++++++++++++++++++++++++++++++++++++++++++++
 fpu/softfloat.h            |   14 ++
 target-arm/cpu.h           |    4 +-
 target-arm/helper.c        |   26 +++-
 target-arm/helper.h        |    3 +
 target-arm/machine.c       |    2 +-
 target-arm/translate.c     |  118 ++++++++++++-
 8 files changed, 760 insertions(+), 12 deletions(-)

[Qemu-devel] [PATCH 8/8] target-arm: Fix use of free() in cpu_arm_close()

[Peter Maydell]

From: Andreas Färber <afaerber@suse.de>

env is allocated in cpu_arm_init() with g_malloc0(), so free with g_free().

Signed-off-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-arm/helper.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/target-arm/helper.c b/target-arm/helper.c
index eddb923..97af4d0 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -475,7 +475,7 @@ static uint32_t cpu_arm_find_by_name(const char *name)
 
 void cpu_arm_close(CPUARMState *env)
 {
-    free(env);
+    g_free(env);
 }
 
 uint32_t cpsr_read(CPUARMState *env)
-- 
1.7.1

Re: [Qemu-devel] [PULL v2 0/8] target-arm queue

[andrzej zaborowski]

On 20 October 2011 16:36, Peter Maydell <peter.maydell@linaro.org> wrote:
> Hi; these are the pending target-arm patches I'd like to get in for 1.0;
> a couple of minor ones plus the A15 insn work. Please pull.
>
> V2 of this pullreq just adds Andreas' trivial patch as 8/8,
> so I haven't bothered re-emailing the identical 1-7, just this
> cover letter and 8/8.

I pulled all the patches, thanks.  I haven't fully verified the
softfloat code added, but I thought the fixes were important enough.

Cheers

Re: [Qemu-devel] [PULL v2 0/8] target-arm queue

[Peter Maydell]

On 27 October 2011 00:13, andrzej zaborowski <balrogg@gmail.com> wrote:
> On 20 October 2011 16:36, Peter Maydell <peter.maydell@linaro.org> wrote:
>> Hi; these are the pending target-arm patches I'd like to get in for 1.0;
>> a couple of minor ones plus the A15 insn work. Please pull.
>>
>> V2 of this pullreq just adds Andreas' trivial patch as 8/8,
>> so I haven't bothered re-emailing the identical 1-7, just this
>> cover letter and 8/8.
>
> I pulled all the patches, thanks.  I haven't fully verified the
> softfloat code added, but I thought the fixes were important enough.

Thanks. Richard H reviewed v1 of the softfloat code and only had
minor comments on it, plus I gave it a pretty thorough testing
workout, so I'm pretty happy it's good.

-- PMM