From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com,
"Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 2/8] configure: Update configure so that open_by_handle_at check returns correct value
Date: Thu, 20 Oct 2011 21:47:34 +0530 [thread overview]
Message-ID: <1319127460-5181-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> (raw)
In-Reply-To: <1319127460-5181-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com>
From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
According to David Gibson for some compiler/libc combinations, open_by_handle_at
test in configure isn't quite right: because the file_handle pointer is never
dereferenced, gcc doesn't complain even if it is undefined. Change the test
as suggested by him.
Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
---
configure | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/configure b/configure
index 4f87e0a..19e8394 100755
--- a/configure
+++ b/configure
@@ -2562,7 +2562,7 @@ fi
open_by_hande_at=no
cat > $TMPC << EOF
#include <fcntl.h>
-int main(void) { struct file_handle *fh; open_by_handle_at(0, fh, 0); }
+int main(void) { struct file_handle fh; open_by_handle_at(0, &fh, 0); }
EOF
if compile_prog "" "" ; then
open_by_handle_at=yes
--
1.7.5.4
next prev parent reply other threads:[~2011-10-20 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-20 16:17 [Qemu-devel] [PATCH 0/8] VirtFS update 7 for review Aneesh Kumar K.V
2011-10-20 16:17 ` [Qemu-devel] [PATCH 1/8] hw/9pfs: Fix error handling in local_mknod Aneesh Kumar K.V
2011-10-20 16:17 ` Aneesh Kumar K.V [this message]
2011-10-20 16:17 ` [Qemu-devel] [PATCH 3/8] qemu: Add opt_set_bool functionality Aneesh Kumar K.V
2011-10-20 16:17 ` [Qemu-devel] [PATCH 4/8] hw/9pfs: Read-only support for 9p export Aneesh Kumar K.V
2011-10-20 16:17 ` [Qemu-devel] [PATCH 5/8] hw/9pfs: Abstract open state of fid to V9fsFidOpenState Aneesh Kumar K.V
2011-10-20 16:17 ` [Qemu-devel] [PATCH 6/8] hw/9pfs: Add synthetic file system support using 9p Aneesh Kumar K.V
2011-10-20 16:17 ` [Qemu-devel] [PATCH 7/8] qemu-queue: Introduce QLIST_INSERT_HEAD_RCU and dummy RCU wrappers Aneesh Kumar K.V
2011-10-20 16:17 ` [Qemu-devel] [PATCH 8/8] hw/9pfs: Replace rwlocks with RCU variants of interfaces Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319127460-5181-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).