qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, aliguori@us.ibm.com,
	mdroth@linux.vnet.ibm.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH v1 00/19]: QAPI conversions round 2
Date: Mon, 24 Oct 2011 11:26:53 -0200	[thread overview]
Message-ID: <1319462832-12199-1-git-send-email-lcapitulino@redhat.com> (raw)

This series completes the conversion of current QMP query commands to the
QAPI framework. IOW, with this series applied no single query command will
be building QObjects by hand.

This series also contains two fixes and some cleanups. One of the fixes
solves a problem with the generated code which ignores errors. The other
fixes a missing error declaration in QError.

There are two important details about this series that should be observed:

 1. This is a bit late in the development process. Although there's a lot
    of code churn involved, query commands are relatively simple: most of
    them don't return errors and they don't take parameters. I've also
    tested them as much as I could.

    I'm not saying it's bug-free, but I believe we have enough time for
    fixing any outstanding issues.

 2. Most query commands makes use of QAPI's list type. Unfortunately, the
    simplest way to build a list reverses the order of listings in HMP
    (ie. the "info cpus" command starts at the last CPU). To avoid this,
    I'm building lists by hand the old way for now. In the short term the
    QAPI will be changed to use glib's list support.

 balloon.c                |   72 +-----
 balloon.h                |    6 +-
 block.c                  |  234 ++++++------------
 block.h                  |    5 -
 block_int.h              |    4 +-
 console.h                |    9 -
 cpus.c                   |   45 ++++
 error.c                  |    3 +-
 hmp-commands.hx          |    3 +-
 hmp.c                    |  407 ++++++++++++++++++++++++++++++
 hmp.h                    |   10 +
 hw/pci-stub.c            |   15 +-
 hw/pci.c                 |  322 +++++++++---------------
 hw/pci.h                 |    4 -
 hw/virtio-balloon.c      |   78 +-----
 input.c                  |   64 ++----
 migration.c              |   82 ++-----
 monitor.c                |  313 ++----------------------
 monitor.h                |    2 +
 qapi-schema.json         |  616 ++++++++++++++++++++++++++++++++++++++++++++++
 qerror.c                 |    4 +
 qmp-commands.hx          |   60 +++++-
 qmp.c                    |   27 ++
 scripts/qapi-commands.py |    4 +-
 ui/spice-core.c          |  139 +++++------
 ui/vnc.c                 |  135 +++++++----
 vl.c                     |    2 +-
 27 files changed, 1611 insertions(+), 1054 deletions(-)

             reply	other threads:[~2011-10-24 13:27 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-24 13:26 Luiz Capitulino [this message]
2011-10-24 13:26 ` [Qemu-devel] [PATCH 01/19] qapi-commands.py: Don't call the output marshal on error Luiz Capitulino
2011-10-24 13:26 ` [Qemu-devel] [PATCH 02/19] qapi: Convert query-mice Luiz Capitulino
2011-10-24 13:26 ` [Qemu-devel] [PATCH 03/19] qapi: Convert query-migrate Luiz Capitulino
2011-10-24 13:26 ` [Qemu-devel] [PATCH 04/19] Monitor: Make mon_set_cpu() public Luiz Capitulino
2011-10-24 13:26 ` [Qemu-devel] [PATCH 05/19] Monitor: Introduce monitor_get_cpu_index() Luiz Capitulino
2011-10-24 13:26 ` [Qemu-devel] [PATCH 06/19] qapi: Convert the cpu command Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 07/19] qapi: Convert query-cpus Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 08/19] block: iostatus: Drop BDRV_IOS_INVAL Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 09/19] block: Rename the BlockIOStatus enum values Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 10/19] qapi: Convert query-block Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 11/19] qapi: Convert query-blockstats Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 12/19] qerror: Add a user string for QERR_FEATURE_DISABLED Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 13/19] qapi: Convert query-vnc Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 14/19] qapi: Convert query-spice Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 15/19] qapi: Convert query-balloon Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 16/19] qapi: Convert query-pci Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 17/19] QMP: Drop the query commands dispatch table Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 18/19] Monitor: do_info(): Drop QMP command handling code Luiz Capitulino
2011-10-24 13:27 ` [Qemu-devel] [PATCH 19/19] Drop qemu-objects.h from modules that don't require it Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319462832-12199-1-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).