From: "Benoît Canet" <benoit.canet@gmail.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Benoît Canet" <benoit.canet@gmail.com>
Subject: [Qemu-devel] [PATCH 08/14] syborg_timer: convert to memory API
Date: Mon, 24 Oct 2011 22:38:27 +0200 [thread overview]
Message-ID: <1319488713-3482-9-git-send-email-benoit.canet@gmail.com> (raw)
In-Reply-To: <1319488713-3482-1-git-send-email-benoit.canet@gmail.com>
Signed-off-by: Benoit Canet <benoit.canet@gmail.com>
---
hw/syborg_timer.c | 27 ++++++++++-----------------
1 files changed, 10 insertions(+), 17 deletions(-)
diff --git a/hw/syborg_timer.c b/hw/syborg_timer.c
index 50c813e..dfee457 100644
--- a/hw/syborg_timer.c
+++ b/hw/syborg_timer.c
@@ -53,6 +53,7 @@ enum {
typedef struct {
SysBusDevice busdev;
+ MemoryRegion iomem;
ptimer_state *timer;
int running;
int oneshot;
@@ -83,7 +84,8 @@ static void syborg_timer_tick(void *opaque)
syborg_timer_update(s);
}
-static uint32_t syborg_timer_read(void *opaque, target_phys_addr_t offset)
+static uint64_t syborg_timer_read(void *opaque, target_phys_addr_t offset,
+ unsigned size)
{
SyborgTimerState *s = (SyborgTimerState *)opaque;
@@ -114,7 +116,7 @@ static uint32_t syborg_timer_read(void *opaque, target_phys_addr_t offset)
}
static void syborg_timer_write(void *opaque, target_phys_addr_t offset,
- uint32_t value)
+ uint64_t value, unsigned size)
{
SyborgTimerState *s = (SyborgTimerState *)opaque;
@@ -162,16 +164,10 @@ static void syborg_timer_write(void *opaque, target_phys_addr_t offset,
}
}
-static CPUReadMemoryFunc * const syborg_timer_readfn[] = {
- syborg_timer_read,
- syborg_timer_read,
- syborg_timer_read
-};
-
-static CPUWriteMemoryFunc * const syborg_timer_writefn[] = {
- syborg_timer_write,
- syborg_timer_write,
- syborg_timer_write
+static const MemoryRegionOps syborg_timer_ops = {
+ .read = syborg_timer_read,
+ .write = syborg_timer_write,
+ .endianness = DEVICE_NATIVE_ENDIAN,
};
static const VMStateDescription vmstate_syborg_timer = {
@@ -194,17 +190,14 @@ static int syborg_timer_init(SysBusDevice *dev)
{
SyborgTimerState *s = FROM_SYSBUS(SyborgTimerState, dev);
QEMUBH *bh;
- int iomemtype;
if (s->freq == 0) {
fprintf(stderr, "syborg_timer: Zero/unset frequency\n");
exit(1);
}
sysbus_init_irq(dev, &s->irq);
- iomemtype = cpu_register_io_memory(syborg_timer_readfn,
- syborg_timer_writefn, s,
- DEVICE_NATIVE_ENDIAN);
- sysbus_init_mmio(dev, 0x1000, iomemtype);
+ memory_region_init_io(&s->iomem, &syborg_timer_ops, s, "timer", 0x1000);
+ sysbus_init_mmio_region(dev, &s->iomem);
bh = qemu_bh_new(syborg_timer_tick, s);
s->timer = ptimer_init(bh);
--
1.7.4.1
next prev parent reply other threads:[~2011-10-24 20:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 20:38 [Qemu-devel] [PATCH 00/14] arm: more memory API and VMState conversion Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 01/14] mst_fpga: convert to memory API Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 02/14] syborg_fb: " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 03/14] syborg_interrupt: " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 04/14] syborg_keyboard: " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 05/14] syborg_pointer: " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 06/14] syborg_rtc: " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 07/14] syborg_serial: " Benoît Canet
2011-10-24 20:38 ` Benoît Canet [this message]
2011-10-24 20:38 ` [Qemu-devel] [PATCH 09/14] syborg_virtio: " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 10/14] pl181: add vmstate Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 11/14] bitbang_i2c: convert to VMState Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 12/14] realview: convert realview i2c " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 13/14] integratorcp: convert integratorcm " Benoît Canet
2011-10-24 20:38 ` [Qemu-devel] [PATCH 14/14] integratorcp: convert icp_pic " Benoît Canet
2011-10-25 8:49 ` [Qemu-devel] [PATCH 00/14] arm: more memory API and VMState conversion Avi Kivity
2011-10-25 9:03 ` Benoît Canet
2011-10-25 11:06 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319488713-3482-9-git-send-email-benoit.canet@gmail.com \
--to=benoit.canet@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).