* [Qemu-devel] [PATCH] savevm: qemu_fille_buffer() used to return one error for reads of size 0.
@ 2011-10-25 17:18 Juan Quintela
2011-10-25 17:46 ` Markus Armbruster
0 siblings, 1 reply; 2+ messages in thread
From: Juan Quintela @ 2011-10-25 17:18 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
savevm.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/savevm.c b/savevm.c
index f01838f..bee16c0 100644
--- a/savevm.c
+++ b/savevm.c
@@ -476,6 +476,8 @@ static void qemu_fill_buffer(QEMUFile *f)
if (len > 0) {
f->buf_size += len;
f->buf_offset += len;
+ } else if (len == 0) {
+ f->last_error = -EIO;
} else if (len != -EAGAIN)
f->last_error = len;
}
--
1.7.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] savevm: qemu_fille_buffer() used to return one error for reads of size 0.
2011-10-25 17:18 [Qemu-devel] [PATCH] savevm: qemu_fille_buffer() used to return one error for reads of size 0 Juan Quintela
@ 2011-10-25 17:46 ` Markus Armbruster
0 siblings, 0 replies; 2+ messages in thread
From: Markus Armbruster @ 2011-10-25 17:46 UTC (permalink / raw)
To: Juan Quintela; +Cc: qemu-devel
Juan Quintela <quintela@redhat.com> writes:
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
> savevm.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/savevm.c b/savevm.c
> index f01838f..bee16c0 100644
> --- a/savevm.c
> +++ b/savevm.c
> @@ -476,6 +476,8 @@ static void qemu_fill_buffer(QEMUFile *f)
> if (len > 0) {
> f->buf_size += len;
> f->buf_offset += len;
> + } else if (len == 0) {
> + f->last_error = -EIO;
> } else if (len != -EAGAIN)
> f->last_error = len;
> }
This reverts an accidental change in commit dcd1d224 migration: change
has_error to contain errno values.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-25 17:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-25 17:18 [Qemu-devel] [PATCH] savevm: qemu_fille_buffer() used to return one error for reads of size 0 Juan Quintela
2011-10-25 17:46 ` Markus Armbruster
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).