From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com
Subject: [Qemu-devel] [PATCH 2/7] block: Fix bdrv_open use after free
Date: Wed, 26 Oct 2011 14:31:17 +0200 [thread overview]
Message-ID: <1319632282-22725-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1319632282-22725-1-git-send-email-kwolf@redhat.com>
tmp_filename was used outside the block it was defined in, i.e. after it went
out of scope. Move its declaration to the top level.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index 86d450c..9dbb572 100644
--- a/block.c
+++ b/block.c
@@ -571,6 +571,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags,
BlockDriver *drv)
{
int ret;
+ char tmp_filename[PATH_MAX];
if (flags & BDRV_O_SNAPSHOT) {
BlockDriverState *bs1;
@@ -578,7 +579,6 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags,
int is_protocol = 0;
BlockDriver *bdrv_qcow2;
QEMUOptionParameter *options;
- char tmp_filename[PATH_MAX];
char backing_filename[PATH_MAX];
/* if snapshot, we create a temporary backing file and open it
--
1.7.6.4
next prev parent reply other threads:[~2011-10-26 12:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 12:31 [Qemu-devel] [PATCH 0/7] block: Collection of unrelated simple fixes Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 1/7] block: Remove dead code Kevin Wolf
2011-10-27 1:50 ` Robert Wang
2011-10-27 7:37 ` Stefan Hajnoczi
2011-10-27 8:23 ` Kevin Wolf
2011-10-26 12:31 ` Kevin Wolf [this message]
2011-10-26 12:31 ` [Qemu-devel] [PATCH 3/7] qcow: Fix bdrv_write_compressed error handling Kevin Wolf
2011-10-27 7:33 ` Paolo Bonzini
2011-10-26 12:31 ` [Qemu-devel] [PATCH 4/7] ide: Fix off-by-one error in array index check Kevin Wolf
2011-10-27 7:32 ` Paolo Bonzini
2011-10-26 12:31 ` [Qemu-devel] [PATCH 5/7] vmdk: Fix use of uninitialised value Kevin Wolf
2011-10-26 13:21 ` Pavel Borzenkov
2011-10-26 13:50 ` Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 6/7] vmdk: Improve error handling Kevin Wolf
2011-10-26 12:31 ` [Qemu-devel] [PATCH 7/7] vmdk: Fix possible segfaults Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319632282-22725-3-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).