From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50630) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4Nh-0001uJ-LQ for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:23:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJ4Ng-00009R-J3 for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:23:01 -0400 Received: from mtagate2.uk.ibm.com ([194.196.100.162]:51909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJ4Ng-0008Um-6Y for qemu-devel@nongnu.org; Wed, 26 Oct 2011 10:23:00 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p9QEMQA8018035 for ; Wed, 26 Oct 2011 14:22:26 GMT Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p9QEMPRV2629782 for ; Wed, 26 Oct 2011 15:22:25 +0100 Received: from d06av07.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p9QEMOIJ010291 for ; Wed, 26 Oct 2011 08:22:25 -0600 From: Stefan Hajnoczi Date: Wed, 26 Oct 2011 15:22:07 +0100 Message-Id: <1319638933-19063-5-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1319638933-19063-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1319638933-19063-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 04/10] qed: don't pass NULL to memcpy List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Stefan Hajnoczi , Pavel Borzenkov From: Pavel Borzenkov Spotted by Clang Analyzer [Note this memcpy call has always been safe because the length will be 0 when the pointer is NULL] Signed-off-by: Pavel Borzenkov Signed-off-by: Stefan Hajnoczi --- block/qed.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/block/qed.c b/block/qed.c index e87dc4d..7fab155 100644 --- a/block/qed.c +++ b/block/qed.c @@ -1425,8 +1425,10 @@ static int bdrv_qed_change_backing_file(BlockDriverState *bs, memcpy(buffer, &le_header, sizeof(le_header)); buffer_len = sizeof(le_header); - memcpy(buffer + buffer_len, backing_file, backing_file_len); - buffer_len += backing_file_len; + if (backing_file) { + memcpy(buffer + buffer_len, backing_file, backing_file_len); + buffer_len += backing_file_len; + } /* Write new header */ ret = bdrv_pwrite_sync(bs->file, 0, buffer, buffer_len); -- 1.7.7