From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, mdroth@linux.vnet.ibm.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH 09/13] virtio-balloon: convert save/load to visitors
Date: Thu, 27 Oct 2011 13:17:21 -0500 [thread overview]
Message-ID: <1319739445-17629-10-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1319739445-17629-1-git-send-email-mdroth@linux.vnet.ibm.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
hw/virtio-balloon.c | 32 ++++++++++++++++++++++++++++----
1 files changed, 28 insertions(+), 4 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index 5f8f4bd..242c58d 100644
--- a/hw/virtio-balloon.c
+++ b/hw/virtio-balloon.c
@@ -246,24 +246,48 @@ static void virtio_balloon_to_target(void *opaque, ram_addr_t target)
static void virtio_balloon_save(QEMUFile *f, void *opaque)
{
VirtIOBalloon *s = opaque;
+ Visitor *v = qemu_file_get_visitor(f);
+ Error *err = NULL;
+
+ visit_start_struct(v, NULL, NULL, "virtio_balloon", 0, &err);
virtio_save(&s->vdev, f);
- qemu_put_be32(f, s->num_pages);
- qemu_put_be32(f, s->actual);
+ visit_type_uint32(v, &s->num_pages, "num_pages", &err);
+ visit_type_uint32(v, &s->actual, "actual", &err);
+
+ visit_end_struct(v, &err);
+
+ if (err) {
+ error_report("error saving virtio-balloon state: %s", error_get_pretty(err));
+ error_free(err);
+ }
}
static int virtio_balloon_load(QEMUFile *f, void *opaque, int version_id)
{
VirtIOBalloon *s = opaque;
+ Visitor *v = qemu_file_get_visitor(f);
+ Error *err = NULL;
if (version_id != 1)
return -EINVAL;
+ visit_start_struct(v, NULL, NULL, "virtio_balloon", 0, &err);
+
virtio_load(&s->vdev, f);
- s->num_pages = qemu_get_be32(f);
- s->actual = qemu_get_be32(f);
+ visit_type_uint32(v, &s->num_pages, "num_pages", &err);
+ visit_type_uint32(v, &s->actual, "actual", &err);
+
+ visit_end_struct(v, &err);
+
+ if (err) {
+ error_report("error loading virtio-balloon state: %s", error_get_pretty(err));
+ error_free(err);
+ return -EINVAL;
+ }
+
return 0;
}
--
1.7.4.1
next prev parent reply other threads:[~2011-10-27 18:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-27 18:17 [Qemu-devel] [PATCH 00/13] Convert slirp/ivshmem/virtio save/load to Visitors Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 01/13] slirp: convert save/load function to visitor interface Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 02/13] ivshmem: convert save/load to visitor Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 03/13] virtio-pci: convert save/load to visitors Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 04/13] msix: convert save/load to visitors (including interfaces) Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 05/13] openpic: convert save/load to visitors Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 06/13] i440fx: " Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 07/13] pci: convert pci_device_(save|load) interfaces to accept Visitors Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 08/13] virtio: convert common virtio save/load to visitors Michael Roth
2011-10-27 18:17 ` Michael Roth [this message]
2011-10-27 18:17 ` [Qemu-devel] [PATCH 10/13] virtio-blk: convert " Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 11/13] virtio-net: " Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 12/13] virtio-serial: " Michael Roth
2011-10-27 18:17 ` [Qemu-devel] [PATCH 13/13] virtio: convert virtio_save/virtio_load interfaces to accept Visitors Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319739445-17629-10-git-send-email-mdroth@linux.vnet.ibm.com \
--to=mdroth@linux.vnet.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).