From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:34275) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RJiB0-0000ke-DK for qemu-devel@nongnu.org; Fri, 28 Oct 2011 04:52:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RJiAy-0002eB-MD for qemu-devel@nongnu.org; Fri, 28 Oct 2011 04:52:34 -0400 From: Markus Armbruster Date: Fri, 28 Oct 2011 10:52:25 +0200 Message-Id: <1319791946-15602-2-git-send-email-armbru@redhat.com> In-Reply-To: <1319791946-15602-1-git-send-email-armbru@redhat.com> References: <1319791946-15602-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] sysbus: Supply missing va_end() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, jvrao@linux.vnet.ibm.com C99 7.15.1: Each invocation of the va_start and va_copy macros shall be matched by a corresponding invocation of the va_end macro in the same function. Spotted by Coverity. Harmless on the (common) systems where va_end() does nothing. Signed-off-by: Markus Armbruster --- hw/sysbus.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 4fab5a4..fd2fc6a 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -198,6 +198,7 @@ DeviceState *sysbus_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; } @@ -229,6 +230,7 @@ DeviceState *sysbus_try_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; } -- 1.7.6.4