* [Qemu-devel] [PATCH] ia64-dis.c: Undefine ABS to avoid clash with glib
@ 2011-10-29 11:58 Peter Maydell
2011-11-01 18:04 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-10-29 11:58 UTC (permalink / raw)
To: qemu-devel; +Cc: Aurelien Jarno, patches
Undefine ABS to avoid a clash with the macro that glib.h
helpfully defines for us (and a resulting build failure
on ia64 hosts).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Bit of a namespace grab by glib.h if you ask me. Undefining
ABS seems the most straightforward fix.
ia64-dis.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/ia64-dis.c b/ia64-dis.c
index 2886df3..2a103e6 100644
--- a/ia64-dis.c
+++ b/ia64-dis.c
@@ -781,6 +781,9 @@ ext_inc3 (const struct ia64_operand *self, ia64_insn code, ia64_insn *valuep)
return 0;
}
+/* glib.h defines ABS so we must undefine it to avoid a clash */
+#undef ABS
+
#define CST IA64_OPND_CLASS_CST
#define REG IA64_OPND_CLASS_REG
#define IND IA64_OPND_CLASS_IND
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] ia64-dis.c: Undefine ABS to avoid clash with glib
2011-10-29 11:58 [Qemu-devel] [PATCH] ia64-dis.c: Undefine ABS to avoid clash with glib Peter Maydell
@ 2011-11-01 18:04 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-11-01 18:04 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, Aurelien Jarno, patches
On 10/29/2011 06:58 AM, Peter Maydell wrote:
> Undefine ABS to avoid a clash with the macro that glib.h
> helpfully defines for us (and a resulting build failure
> on ia64 hosts).
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> Bit of a namespace grab by glib.h if you ask me. Undefining
> ABS seems the most straightforward fix.
>
> ia64-dis.c | 3 +++
> 1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/ia64-dis.c b/ia64-dis.c
> index 2886df3..2a103e6 100644
> --- a/ia64-dis.c
> +++ b/ia64-dis.c
> @@ -781,6 +781,9 @@ ext_inc3 (const struct ia64_operand *self, ia64_insn code, ia64_insn *valuep)
> return 0;
> }
>
> +/* glib.h defines ABS so we must undefine it to avoid a clash */
> +#undef ABS
> +
> #define CST IA64_OPND_CLASS_CST
> #define REG IA64_OPND_CLASS_REG
> #define IND IA64_OPND_CLASS_IND
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-01 18:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-29 11:58 [Qemu-devel] [PATCH] ia64-dis.c: Undefine ABS to avoid clash with glib Peter Maydell
2011-11-01 18:04 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).