qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 17/17] pl190: convert to memory API
Date: Sun, 30 Oct 2011 16:33:54 +0200	[thread overview]
Message-ID: <1319985234-32371-18-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1319985234-32371-1-git-send-email-avi@redhat.com>

Signed-off-by: Avi Kivity <avi@redhat.com>
---
 hw/pl190.c |   28 +++++++++++-----------------
 1 files changed, 11 insertions(+), 17 deletions(-)

diff --git a/hw/pl190.c b/hw/pl190.c
index 8dc7e42..a3d008d 100644
--- a/hw/pl190.c
+++ b/hw/pl190.c
@@ -17,6 +17,7 @@
 
 typedef struct {
     SysBusDevice busdev;
+    MemoryRegion iomem;
     uint32_t level;
     uint32_t soft_level;
     uint32_t irq_enable;
@@ -84,7 +85,8 @@ static void pl190_update_vectors(pl190_state *s)
     pl190_update(s);
 }
 
-static uint32_t pl190_read(void *opaque, target_phys_addr_t offset)
+static uint64_t pl190_read(void *opaque, target_phys_addr_t offset,
+                           unsigned size)
 {
     pl190_state *s = (pl190_state *)opaque;
     int i;
@@ -140,7 +142,8 @@ static uint32_t pl190_read(void *opaque, target_phys_addr_t offset)
     }
 }
 
-static void pl190_write(void *opaque, target_phys_addr_t offset, uint32_t val)
+static void pl190_write(void *opaque, target_phys_addr_t offset,
+                        uint64_t val, unsigned size)
 {
     pl190_state *s = (pl190_state *)opaque;
 
@@ -199,16 +202,10 @@ static void pl190_write(void *opaque, target_phys_addr_t offset, uint32_t val)
     pl190_update(s);
 }
 
-static CPUReadMemoryFunc * const pl190_readfn[] = {
-   pl190_read,
-   pl190_read,
-   pl190_read
-};
-
-static CPUWriteMemoryFunc * const pl190_writefn[] = {
-   pl190_write,
-   pl190_write,
-   pl190_write
+static const MemoryRegionOps pl190_ops = {
+    .read = pl190_read,
+    .write = pl190_write,
+    .endianness = DEVICE_NATIVE_ENDIAN,
 };
 
 static void pl190_reset(DeviceState *d)
@@ -230,12 +227,9 @@ static void pl190_reset(DeviceState *d)
 static int pl190_init(SysBusDevice *dev)
 {
     pl190_state *s = FROM_SYSBUS(pl190_state, dev);
-    int iomemtype;
 
-    iomemtype = cpu_register_io_memory(pl190_readfn,
-                                       pl190_writefn, s,
-                                       DEVICE_NATIVE_ENDIAN);
-    sysbus_init_mmio(dev, 0x1000, iomemtype);
+    memory_region_init_io(&s->iomem, &pl190_ops, s, "pl190", 0x1000);
+    sysbus_init_mmio_region(dev, &s->iomem);
     qdev_init_gpio_in(&dev->qdev, pl190_set_irq, 32);
     sysbus_init_irq(dev, &s->irq);
     sysbus_init_irq(dev, &s->fiq);
-- 
1.7.6.3

      parent reply	other threads:[~2011-10-30 14:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-30 14:33 [Qemu-devel] [PATCH 00/17] Memory API conversions, batch 13 Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 01/17] tosa: convert to memory API Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 02/17] versatilepb: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 03/17] vexpress: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 04/17] virtex_ml507: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 05/17] shix: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 06/17] jazz_led: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 07/17] parallel: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 08/17] zaurus: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 09/17] pl011: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 10/17] pl022: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 11/17] pl031: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 12/17] pl050: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 13/17] pl061: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 14/17] pl080: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 15/17] pl110: " Avi Kivity
2011-10-30 14:33 ` [Qemu-devel] [PATCH 16/17] pl181: " Avi Kivity
2011-10-30 14:33 ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319985234-32371-18-git-send-email-avi@redhat.com \
    --to=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).