From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:40587) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKrtn-0003Y6-Ea for qemu-devel@nongnu.org; Mon, 31 Oct 2011 09:27:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKrtm-00048O-Dk for qemu-devel@nongnu.org; Mon, 31 Oct 2011 09:27:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:61722) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKrtm-000486-3J for qemu-devel@nongnu.org; Mon, 31 Oct 2011 09:27:34 -0400 From: Kevin Wolf Date: Mon, 31 Oct 2011 14:29:41 +0100 Message-Id: <1320067830-12093-7-git-send-email-kwolf@redhat.com> In-Reply-To: <1320067830-12093-1-git-send-email-kwolf@redhat.com> References: <1320067830-12093-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 06/55] block: Fix bdrv_open use after free List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org tmp_filename was used outside the block it was defined in, i.e. after it went out of scope. Move its declaration to the top level. Signed-off-by: Kevin Wolf --- block.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block.c b/block.c index f86984f..d5ec0be 100644 --- a/block.c +++ b/block.c @@ -571,6 +571,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *drv) { int ret; + char tmp_filename[PATH_MAX]; if (flags & BDRV_O_SNAPSHOT) { BlockDriverState *bs1; @@ -578,7 +579,6 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, int is_protocol = 0; BlockDriver *bdrv_qcow2; QEMUOptionParameter *options; - char tmp_filename[PATH_MAX]; char backing_filename[PATH_MAX]; /* if snapshot, we create a temporary backing file and open it -- 1.7.6.4