From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:37012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKuSf-0006lW-BS for qemu-devel@nongnu.org; Mon, 31 Oct 2011 12:11:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RKuSc-0004Fh-QN for qemu-devel@nongnu.org; Mon, 31 Oct 2011 12:11:45 -0400 Received: from oxygen.pond.sub.org ([78.46.104.156]:49003) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RKuSc-0004FA-Kw for qemu-devel@nongnu.org; Mon, 31 Oct 2011 12:11:42 -0400 From: Markus Armbruster Date: Mon, 31 Oct 2011 17:11:38 +0100 Message-Id: <1320077498-692-3-git-send-email-armbru@redhat.com> In-Reply-To: <1320077498-692-1-git-send-email-armbru@redhat.com> References: <1320077498-692-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 2/2] net: socket backend shows junk in "info network", fix List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com net_socket_fd_init_dgram() prints uninitialized saddr into nc->info_str. Spotted by Coverity. Signed-off-by: Markus Armbruster --- net/socket.c | 13 +++++++++---- 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/net/socket.c b/net/socket.c index eb3e0d6..42bbae4 100644 --- a/net/socket.c +++ b/net/socket.c @@ -288,10 +288,15 @@ static NetSocketState *net_socket_fd_init_dgram(VLANState *vlan, nc = qemu_new_net_client(&net_dgram_socket_info, vlan, NULL, model, name); - snprintf(nc->info_str, sizeof(nc->info_str), - "socket: fd=%d (%s mcast=%s:%d)", - fd, is_connected ? "cloned" : "", - inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + if (is_connected) { + snprintf(nc->info_str, sizeof(nc->info_str), + "socket: fd=%d (cloned mcast=%s:%d)", + fd, inet_ntoa(saddr.sin_addr), ntohs(saddr.sin_port)); + } else { + snprintf(nc->info_str, sizeof(nc->info_str), + "socket: fd=%d", + fd); + } s = DO_UPCAST(NetSocketState, nc, nc); -- 1.7.6.4