qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
	Markus Armbruster <armbru@redhat.com>,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 2/4] sysbus: Supply missing va_end()
Date: Tue,  1 Nov 2011 06:27:08 +0000	[thread overview]
Message-ID: <1320128830-25943-3-git-send-email-stefanha@linux.vnet.ibm.com> (raw)
In-Reply-To: <1320128830-25943-1-git-send-email-stefanha@linux.vnet.ibm.com>

From: Markus Armbruster <armbru@redhat.com>

C99 7.15.1: Each invocation of the va_start and va_copy macros shall
be matched by a corresponding invocation of the va_end macro in the
same function.

Spotted by Coverity.  Harmless on the (common) systems where va_end()
does nothing.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 hw/sysbus.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/hw/sysbus.c b/hw/sysbus.c
index 4fab5a4..fd2fc6a 100644
--- a/hw/sysbus.c
+++ b/hw/sysbus.c
@@ -198,6 +198,7 @@ DeviceState *sysbus_create_varargs(const char *name,
         sysbus_connect_irq(s, n, irq);
         n++;
     }
+    va_end(va);
     return dev;
 }
 
@@ -229,6 +230,7 @@ DeviceState *sysbus_try_create_varargs(const char *name,
         sysbus_connect_irq(s, n, irq);
         n++;
     }
+    va_end(va);
     return dev;
 }
 
-- 
1.7.7

  parent reply	other threads:[~2011-11-01  6:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01  6:27 [Qemu-devel] [PULL 0/4] Trivial patches for 27 October to 1 November 2011 Stefan Hajnoczi
2011-11-01  6:27 ` [Qemu-devel] [PATCH 1/4] net: tap-linux: Fix unhelpful error message Stefan Hajnoczi
2011-11-01  6:27 ` Stefan Hajnoczi [this message]
2011-11-01  6:27 ` [Qemu-devel] [PATCH 3/4] qapi: fix typos in documentation JSON examples Stefan Hajnoczi
2011-11-01  6:27 ` [Qemu-devel] [PATCH 4/4] acl: Fix use after free in qemu_acl_reset() Stefan Hajnoczi
2011-11-01 18:14 ` [Qemu-devel] [PULL 0/4] Trivial patches for 27 October to 1 November 2011 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320128830-25943-3-git-send-email-stefanha@linux.vnet.ibm.com \
    --to=stefanha@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).