From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:36619) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL7of-0002Is-CP for qemu-devel@nongnu.org; Tue, 01 Nov 2011 02:27:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RL7od-0004Hs-82 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 02:27:21 -0400 Received: from mtagate7.uk.ibm.com ([194.196.100.167]:40982) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RL7oc-0004HU-W5 for qemu-devel@nongnu.org; Tue, 01 Nov 2011 02:27:19 -0400 Received: from d06nrmr1507.portsmouth.uk.ibm.com (d06nrmr1507.portsmouth.uk.ibm.com [9.149.38.233]) by mtagate7.uk.ibm.com (8.13.1/8.13.1) with ESMTP id pA16RHfO008288 for ; Tue, 1 Nov 2011 06:27:17 GMT Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by d06nrmr1507.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id pA16RHg72310312 for ; Tue, 1 Nov 2011 06:27:17 GMT Received: from d06av01.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id pA16RHgP022832 for ; Tue, 1 Nov 2011 00:27:17 -0600 From: Stefan Hajnoczi Date: Tue, 1 Nov 2011 06:27:08 +0000 Message-Id: <1320128830-25943-3-git-send-email-stefanha@linux.vnet.ibm.com> In-Reply-To: <1320128830-25943-1-git-send-email-stefanha@linux.vnet.ibm.com> References: <1320128830-25943-1-git-send-email-stefanha@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 2/4] sysbus: Supply missing va_end() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony Liguori , Markus Armbruster , Stefan Hajnoczi From: Markus Armbruster C99 7.15.1: Each invocation of the va_start and va_copy macros shall be matched by a corresponding invocation of the va_end macro in the same function. Spotted by Coverity. Harmless on the (common) systems where va_end() does nothing. Signed-off-by: Markus Armbruster Signed-off-by: Stefan Hajnoczi --- hw/sysbus.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/sysbus.c b/hw/sysbus.c index 4fab5a4..fd2fc6a 100644 --- a/hw/sysbus.c +++ b/hw/sysbus.c @@ -198,6 +198,7 @@ DeviceState *sysbus_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; } @@ -229,6 +230,7 @@ DeviceState *sysbus_try_create_varargs(const char *name, sysbus_connect_irq(s, n, irq); n++; } + va_end(va); return dev; } -- 1.7.7