qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check
@ 2011-11-01 18:32 Peter Maydell
  2011-11-01 22:22 ` Anthony Liguori
  0 siblings, 1 reply; 2+ messages in thread
From: Peter Maydell @ 2011-11-01 18:32 UTC (permalink / raw)
  To: qemu-devel; +Cc: qemu-trivial

Suppress confusing messages from pkg_config when probing for
'check' by sending them to /dev/null as we do with other
similar probes.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
We didn't notice this before because we only recently
changed the default for whether configure probed for this.
I think that makes this a regression we should fix for 1.0.

 configure |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/configure b/configure
index 28667fe..9661b0e 100755
--- a/configure
+++ b/configure
@@ -1828,7 +1828,7 @@ if test "$check_utests" != "no" ; then
 #include <check.h>
 int main(void) { suite_create("qemu test"); return 0; }
 EOF
-  check_libs=`$pkg_config --libs check`
+  check_libs=`$pkg_config --libs check 2>/dev/null`
   if compile_prog "" $check_libs ; then
     check_utests=yes
     libs_tools="$check_libs $libs_tools"
-- 
1.7.4.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check
  2011-11-01 18:32 [Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check Peter Maydell
@ 2011-11-01 22:22 ` Anthony Liguori
  0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-11-01 22:22 UTC (permalink / raw)
  To: Peter Maydell; +Cc: qemu-trivial, qemu-devel

On 11/01/2011 01:32 PM, Peter Maydell wrote:
> Suppress confusing messages from pkg_config when probing for
> 'check' by sending them to /dev/null as we do with other
> similar probes.
>
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
> We didn't notice this before because we only recently
> changed the default for whether configure probed for this.
> I think that makes this a regression we should fix for 1.0.
>
>   configure |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index 28667fe..9661b0e 100755
> --- a/configure
> +++ b/configure
> @@ -1828,7 +1828,7 @@ if test "$check_utests" != "no" ; then
>   #include<check.h>
>   int main(void) { suite_create("qemu test"); return 0; }
>   EOF
> -  check_libs=`$pkg_config --libs check`
> +  check_libs=`$pkg_config --libs check 2>/dev/null`
>     if compile_prog "" $check_libs ; then
>       check_utests=yes
>       libs_tools="$check_libs $libs_tools"

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-01 22:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-01 18:32 [Qemu-devel] [PATCH] configure: Suppress messages from pkg_config probe for check Peter Maydell
2011-11-01 22:22 ` Anthony Liguori

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).