qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michael Roth <mdroth@linux.vnet.ibm.com>,
	Juan Quintela <quintela@redhat.com>
Subject: [Qemu-devel] [RFC PATCH 11/11] unix_close(): check for close() errors too
Date: Tue,  1 Nov 2011 17:20:30 -0200	[thread overview]
Message-ID: <1320175230-27980-12-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1320175230-27980-1-git-send-email-ehabkost@redhat.com>

In case close() fails, we want to report the error back.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 migration-unix.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/migration-unix.c b/migration-unix.c
index 8596353..197285c 100644
--- a/migration-unix.c
+++ b/migration-unix.c
@@ -40,12 +40,14 @@ static int unix_write(MigrationState *s, const void * buf, size_t size)
 
 static int unix_close(MigrationState *s)
 {
+    int r = 0;
     DPRINTF("unix_close\n");
     if (s->fd != -1) {
-        close(s->fd);
+        if (close(s->fd) < 0)
+            r = -errno;
         s->fd = -1;
     }
-    return 0;
+    return r;
 }
 
 static void unix_wait_for_connect(void *opaque)
-- 
1.7.3.2

  parent reply	other threads:[~2011-11-01 19:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 19:20 [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 01/11] savevm: use qemu_file_set_error() instead of setting last_error directly Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 02/11] QEMUFileCloseFunc: add return value documentation Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 03/11] exec_close(): accept any negative value as qemu_fclose() error Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 04/11] migrate_fd_cleanup: accept any negative qemu_fclose() value as error Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 05/11] qemu_fclose: return last_error if set Eduardo Habkost
2011-11-02  7:33   ` Paolo Bonzini
2011-11-02 11:56     ` Eduardo Habkost
2011-11-02 12:15       ` Paolo Bonzini
2011-11-02 12:26         ` Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 06/11] stdio_pclose: return -errno on error Eduardo Habkost
2011-11-02 12:32   ` Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 07/11] stdio_fclose: return -errno on errors Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 08/11] exec_close(): " Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 09/11] fd_close(): check for close() errors too Eduardo Habkost
2011-11-01 19:20 ` [Qemu-devel] [RFC PATCH 10/11] tcp_close(): " Eduardo Habkost
2011-11-01 19:20 ` Eduardo Habkost [this message]
2011-11-02  9:50 ` [Qemu-devel] [RFC PATCH 00/11] qemu_fclose() error handling fixes Juan Quintela
2011-11-04 16:32 ` Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320175230-27980-12-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).