qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: "Andreas Färber" <andreas.faerber@web.de>,
	"Juan Pineda" <juan@logician.com>
Subject: [Qemu-devel] [PATCH 3/3] cocoa: Close sheet after image file selection
Date: Tue,  1 Nov 2011 20:56:29 +0100	[thread overview]
Message-ID: <1320177389-22498-4-git-send-email-andreas.faerber@web.de> (raw)
In-Reply-To: <1320177389-22498-1-git-send-email-andreas.faerber@web.de>

If no disk image is specified, the Cocoa frontend displays a modal sheet
to let the user select an image file to boot from.

This sheet is never closed and it permanently obscures the emulator window.

Close it after obtaining the file name in case the user did select a file.
Otherwise we exit immediately, so no need to close then.

Signed-off-by: Juan Pineda <juan@logician.com>
Signed-off-by: Andreas Färber <andreas.faerber@web.de>
---
 ui/cocoa.m |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/ui/cocoa.m b/ui/cocoa.m
index d9e4e3d..0711205 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -811,6 +811,8 @@ QemuCocoaView *cocoaView;
 
         char **argv = (char**)malloc( sizeof(char*)*3 );
 
+        [sheet close];
+
         asprintf(&argv[0], "%s", bin);
         asprintf(&argv[1], "-hda");
         asprintf(&argv[2], "%s", img);
-- 
1.7.0.3

  parent reply	other threads:[~2011-11-01 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-01 19:56 [Qemu-devel] [PULL 0/3] Cocoa fixes for 1.0 Andreas Färber
2011-11-01 19:56 ` [Qemu-devel] [PATCH 1/3] MAINTAINERS: Add Cocoa maintainer Andreas Färber
2011-11-01 19:56 ` [Qemu-devel] [PATCH 2/3] vl.c: Guard against GThread double-initialization Andreas Färber
2011-11-01 19:56 ` Andreas Färber [this message]
2011-11-01 22:42 ` [Qemu-devel] [PULL 0/3] Cocoa fixes for 1.0 Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320177389-22498-4-git-send-email-andreas.faerber@web.de \
    --to=andreas.faerber@web.de \
    --cc=juan@logician.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).