From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:47732) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLMUU-0002Cz-DY for qemu-devel@nongnu.org; Tue, 01 Nov 2011 18:07:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RLMUR-00058g-2W for qemu-devel@nongnu.org; Tue, 01 Nov 2011 18:07:30 -0400 Received: from mail-vw0-f45.google.com ([209.85.212.45]:33693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RLMUQ-00058U-Tn for qemu-devel@nongnu.org; Tue, 01 Nov 2011 18:07:26 -0400 Received: by vws17 with SMTP id 17so1757075vws.4 for ; Tue, 01 Nov 2011 15:07:26 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Tue, 1 Nov 2011 15:06:42 -0700 Message-Id: <1320185203-28036-1-git-send-email-rth@twiddle.net> Subject: [Qemu-devel] [PATCH 1/2] tcg: Fix regression in tcg_gen_deposit_i64. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com, agraf@suse.de The error being caused by the failure to copy the other half of the input to the output after having narrowed the deposit operation. Signed-off-by: Richard Henderson --- tcg/tcg-op.h | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h index 24ec7fc..8637fe8 100644 --- a/tcg/tcg-op.h +++ b/tcg/tcg-op.h @@ -2090,6 +2090,7 @@ static inline void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, #if TCG_TARGET_REG_BITS == 32 if (ofs >= 32) { + tcg_gen_mov_i32(TCGV_LOW(ret), TCGV_LOW(arg1)); tcg_gen_deposit_i32(TCGV_HIGH(ret), TCGV_HIGH(arg1), TCGV_LOW(arg2), ofs - 32, len); return; @@ -2097,6 +2098,7 @@ static inline void tcg_gen_deposit_i64(TCGv_i64 ret, TCGv_i64 arg1, if (ofs + len <= 32) { tcg_gen_deposit_i32(TCGV_LOW(ret), TCGV_LOW(arg1), TCGV_LOW(arg2), ofs, len); + tcg_gen_mov_i32(TCGV_HIGH(ret), TCGV_HIGH(arg1)); return; } #endif -- 1.7.6.4