Re: [Qemu-devel] [PATCH] usb: queue can have async packets too

[Erik Rull <erik.rull@rdsoftware.de>]

On February 28, 2012 at 3:36 PM Gerd Hoffmann <kraxel@redhat.com> wrote:

> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> ---
>  hw/usb.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
>
> diff --git a/hw/usb.c b/hw/usb.c
> index 57fc5e3..fc41d62 100644
> --- a/hw/usb.c
> +++ b/hw/usb.c
> @@ -356,6 +356,9 @@ void usb_packet_complete(USBDevice *dev, USBPacket
*p)
> 
>      while (!QTAILQ_EMPTY(&ep->queue)) {
>          p = QTAILQ_FIRST(&ep->queue);
> +        if (p->state == USB_PACKET_ASYNC) {
> +            break;
> +        }
>          assert(p->state == USB_PACKET_QUEUED);
>          ret = usb_process_one(p);
>          if (ret == USB_RET_ASYNC) {
> --
> 1.7.1
>
>


Hi Gerd,

this fixes my issue.

But: This + the latest GIT master causes again my problems with the
incomplete routing of host devices if the devices are plugged in before
starting up the guest. They are marked with a yellow exclamation mark in
the XP device manager. If I plug them in later, they are working fine.

This was working before the commit that cause the assertion and is now not
working again.

Please have a look at that!

Best regards,

Erik