From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44179) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3SJh-0003q3-BA for qemu-devel@nongnu.org; Fri, 02 Mar 2012 08:14:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3SJa-0006CS-Ue for qemu-devel@nongnu.org; Fri, 02 Mar 2012 08:14:36 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:50477) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3SJa-0006CA-L8 for qemu-devel@nongnu.org; Fri, 02 Mar 2012 08:14:30 -0500 Date: Fri, 2 Mar 2012 14:14:28 +0100 (CET) From: Erik Rull Message-ID: <1320283975.776120.1330694068111.JavaMail.open-xchange@email.1und1.de> In-Reply-To: <1330439808-524-1-git-send-email-kraxel@redhat.com> References: <1330439808-524-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] usb: queue can have async packets too Reply-To: Erik Rull List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Gerd Hoffmann On February 28, 2012 at 3:36 PM Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/usb.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/hw/usb.c b/hw/usb.c > index 57fc5e3..fc41d62 100644 > --- a/hw/usb.c > +++ b/hw/usb.c > @@ -356,6 +356,9 @@ void usb_packet_complete(USBDevice *dev, USBPacket *p) > > while (!QTAILQ_EMPTY(&ep->queue)) { > p = QTAILQ_FIRST(&ep->queue); > + if (p->state == USB_PACKET_ASYNC) { > + break; > + } > assert(p->state == USB_PACKET_QUEUED); > ret = usb_process_one(p); > if (ret == USB_RET_ASYNC) { > -- > 1.7.1 > > Hi Gerd, this fixes my issue. But: This + the latest GIT master causes again my problems with the incomplete routing of host devices if the devices are plugged in before starting up the guest. They are marked with a yellow exclamation mark in the XP device manager. If I plug them in later, they are working fine. This was working before the commit that cause the assertion and is now not working again. Please have a look at that! Best regards, Erik