qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Takashi Iwai <tiwai@suse.de>, Gerd Hoffmann <kraxel@redhat.com>,
	kvm@vger.kernel.org
Subject: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id
Date: Mon,  7 Nov 2011 12:00:34 +0100	[thread overview]
Message-ID: <1320663634-29453-1-git-send-email-kraxel@redhat.com> (raw)

This patch removes the code lines which set the subsystem id for the
emulated ac97 card to 8086:0000.  Due to the device id being zero the
subsystem id isn't vaild anyway.  With the patch applied the sound card
gets the default qemu subsystem id (1af4:1100) instead.

Cc: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/ac97.c |    6 ------
 1 files changed, 0 insertions(+), 6 deletions(-)

diff --git a/hw/ac97.c b/hw/ac97.c
index 6800af4..b43e435 100644
--- a/hw/ac97.c
+++ b/hw/ac97.c
@@ -1305,12 +1305,6 @@ static int ac97_initfn (PCIDevice *dev)
     c[PCI_BASE_ADDRESS_0 + 6] = 0x00;
     c[PCI_BASE_ADDRESS_0 + 7] = 0x00;
 
-    c[PCI_SUBSYSTEM_VENDOR_ID] = 0x86;      /* svid subsystem vendor id rwo */
-    c[PCI_SUBSYSTEM_VENDOR_ID + 1] = 0x80;
-
-    c[PCI_SUBSYSTEM_ID] = 0x00;      /* sid subsystem id rwo */
-    c[PCI_SUBSYSTEM_ID + 1] = 0x00;
-
     c[PCI_INTERRUPT_LINE] = 0x00;      /* intr_ln interrupt line rw */
     c[PCI_INTERRUPT_PIN] = 0x01;      /* intr_pn interrupt pin ro */
 
-- 
1.7.1

             reply	other threads:[~2011-11-07 11:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 11:00 Gerd Hoffmann [this message]
2011-11-07 14:17 ` [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id Avi Kivity
2011-11-07 14:33   ` Gerd Hoffmann
2011-11-07 14:39     ` Anthony Liguori
2011-11-07 14:42     ` Avi Kivity
2011-11-07 14:44       ` Anthony Liguori
2011-11-07 14:50         ` Avi Kivity
2011-11-07 14:53           ` Anthony Liguori
2011-11-07 15:00             ` Avi Kivity
2011-11-07 15:10               ` Gerd Hoffmann
2011-11-07 15:15                 ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320663634-29453-1-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).