From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 09/11] vvfat: unify and correct computation of sector count
Date: Mon, 7 Nov 2011 17:55:16 +0100 [thread overview]
Message-ID: <1320684918-6483-10-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1320684918-6483-1-git-send-email-kwolf@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
The sector count is stored in the partition and hence must not include the
sectors before its start. At the same time, remove the useless special
casing for 1.44 MB floppies. This fixes fsck on VVFAT hard disks,
which otherwise tries to seek past the end of the disk.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/vvfat.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/block/vvfat.c b/block/vvfat.c
index 1f7cc48..3e7b407 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -1026,8 +1026,6 @@ DLOG(if (stderr == NULL) {
bs->cyls = 80; bs->heads = 2; bs->secs = 36;
}
- s->sector_count=bs->cyls*bs->heads*bs->secs;
-
if (strstr(dirname, ":32:")) {
fprintf(stderr, "Big fat greek warning: FAT32 has not been tested. You are welcome to do so!\n");
s->fat_type = 32;
@@ -1035,9 +1033,11 @@ DLOG(if (stderr == NULL) {
s->fat_type = 16;
} else if (strstr(dirname, ":12:")) {
s->fat_type = 12;
- s->sector_count=2880;
+ bs->secs = 18;
}
+ s->sector_count=bs->cyls*bs->heads*bs->secs-(s->first_sectors_number-1);
+
if (strstr(dirname, ":rw:")) {
if (enable_write_target(s))
return -1;
--
1.7.6.4
next prev parent reply other threads:[~2011-11-07 16:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 16:55 [Qemu-devel] [PATCH 00/11] Block patches for 1.0 Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 01/11] qemu-io: Handle create_iovec errors Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 02/11] qemu-io: Fix multiwrite_f error handling Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 03/11] dma: Avoid reentrancy in DMA transfer handlers Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 04/11] block/cloop: Fix coding style Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 05/11] block/cloop: Use g_free instead of free Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 06/11] vvfat: fix out of bounds array_get usage Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 07/11] vvfat: do not fail if the disk has spare sectors Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 08/11] vvfat: need to use first_sectors_number to distinguish fdd/hdd Kevin Wolf
2011-11-07 16:55 ` Kevin Wolf [this message]
2011-11-07 16:55 ` [Qemu-devel] [PATCH 10/11] vvfat: do not hardcode sector counts in error message Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 11/11] vvfat: reorganize computation of disk geometry Kevin Wolf
2011-11-07 16:57 ` [Qemu-devel] [PULL 00/11] Block patches for 1.0 Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320684918-6483-10-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).