qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 07/11] vvfat: do not fail if the disk has spare sectors
Date: Mon,  7 Nov 2011 17:55:14 +0100	[thread overview]
Message-ID: <1320684918-6483-8-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1320684918-6483-1-git-send-email-kwolf@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

If the number of "faked sectors" + the number of sectors that are
part of a cluster does not sum up to the total number of sectors,
qemu-img convert fails.  Read these spare sectors as all zeros.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/vvfat.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index 75d0dc0..9f851b0 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -1245,7 +1245,7 @@ static int vvfat_read(BlockDriverState *bs, int64_t sector_num,
     int i;
 
     for(i=0;i<nb_sectors;i++,sector_num++) {
-	if (sector_num >= s->sector_count)
+	if (sector_num >= bs->total_sectors)
 	   return -1;
 	if (s->qcow) {
 	    int n;
@@ -1271,7 +1271,7 @@ DLOG(fprintf(stderr, "sector %d not allocated\n", (int)sector_num));
 	    uint32_t sector=sector_num-s->faked_sectors,
 	    sector_offset_in_cluster=(sector%s->sectors_per_cluster),
 	    cluster_num=sector/s->sectors_per_cluster;
-	    if(read_cluster(s, cluster_num) != 0) {
+	    if(cluster_num > s->cluster_count || read_cluster(s, cluster_num) != 0) {
 		/* LATER TODO: strict: return -1; */
 		memset(buf+i*0x200,0,0x200);
 		continue;
-- 
1.7.6.4

  parent reply	other threads:[~2011-11-07 16:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 16:55 [Qemu-devel] [PATCH 00/11] Block patches for 1.0 Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 01/11] qemu-io: Handle create_iovec errors Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 02/11] qemu-io: Fix multiwrite_f error handling Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 03/11] dma: Avoid reentrancy in DMA transfer handlers Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 04/11] block/cloop: Fix coding style Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 05/11] block/cloop: Use g_free instead of free Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 06/11] vvfat: fix out of bounds array_get usage Kevin Wolf
2011-11-07 16:55 ` Kevin Wolf [this message]
2011-11-07 16:55 ` [Qemu-devel] [PATCH 08/11] vvfat: need to use first_sectors_number to distinguish fdd/hdd Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 09/11] vvfat: unify and correct computation of sector count Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 10/11] vvfat: do not hardcode sector counts in error message Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 11/11] vvfat: reorganize computation of disk geometry Kevin Wolf
2011-11-07 16:57 ` [Qemu-devel] [PULL 00/11] Block patches for 1.0 Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320684918-6483-8-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).