qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: anthony@codemonkey.ws
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 08/11] vvfat: need to use first_sectors_number to distinguish fdd/hdd
Date: Mon,  7 Nov 2011 17:55:15 +0100	[thread overview]
Message-ID: <1320684918-6483-9-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1320684918-6483-1-git-send-email-kwolf@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

This is consistent with what "real" floppies have, so file(1)
now actually recognizes the VVFAT image as a 1.44 MB floppy.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/vvfat.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index 9f851b0..1f7cc48 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -954,7 +954,7 @@ static int init_directories(BDRVVVFATState* s,
     bootsector->number_of_fats=0x2; /* number of FATs */
     bootsector->root_entries=cpu_to_le16(s->sectors_of_root_directory*0x10);
     bootsector->total_sectors16=s->sector_count>0xffff?0:cpu_to_le16(s->sector_count);
-    bootsector->media_type=(s->fat_type!=12?0xf8:s->sector_count==5760?0xf9:0xf8); /* media descriptor */
+    bootsector->media_type=(s->first_sectors_number>1?0xf8:0xf0); /* media descriptor (f8=hd, f0=3.5 fd)*/
     s->fat.pointer[0] = bootsector->media_type;
     bootsector->sectors_per_fat=cpu_to_le16(s->sectors_per_fat);
     bootsector->sectors_per_track=cpu_to_le16(s->bs->secs);
@@ -963,7 +963,7 @@ static int init_directories(BDRVVVFATState* s,
     bootsector->total_sectors=cpu_to_le32(s->sector_count>0xffff?s->sector_count:0);
 
     /* LATER TODO: if FAT32, this is wrong */
-    bootsector->u.fat16.drive_number=s->fat_type==12?0:0x80; /* assume this is hda (TODO) */
+    bootsector->u.fat16.drive_number=s->first_sectors_number==1?0:0x80; /* fda=0, hda=0x80 */
     bootsector->u.fat16.current_head=0;
     bootsector->u.fat16.signature=0x29;
     bootsector->u.fat16.id=cpu_to_le32(0xfabe1afd);
-- 
1.7.6.4

  parent reply	other threads:[~2011-11-07 16:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-07 16:55 [Qemu-devel] [PATCH 00/11] Block patches for 1.0 Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 01/11] qemu-io: Handle create_iovec errors Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 02/11] qemu-io: Fix multiwrite_f error handling Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 03/11] dma: Avoid reentrancy in DMA transfer handlers Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 04/11] block/cloop: Fix coding style Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 05/11] block/cloop: Use g_free instead of free Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 06/11] vvfat: fix out of bounds array_get usage Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 07/11] vvfat: do not fail if the disk has spare sectors Kevin Wolf
2011-11-07 16:55 ` Kevin Wolf [this message]
2011-11-07 16:55 ` [Qemu-devel] [PATCH 09/11] vvfat: unify and correct computation of sector count Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 10/11] vvfat: do not hardcode sector counts in error message Kevin Wolf
2011-11-07 16:55 ` [Qemu-devel] [PATCH 11/11] vvfat: reorganize computation of disk geometry Kevin Wolf
2011-11-07 16:57 ` [Qemu-devel] [PULL 00/11] Block patches for 1.0 Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1320684918-6483-9-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).