[Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[Chen Wei-Ren (陳韋任)]

From: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>

  According to [1], libqemu is not available anymore. Remove libqemu
related stuff from QEMU source tree.

[1] http://www.mail-archive.com/qemu-devel@nongnu.org/msg49809.html

Chen Wen-Ren (6):
  tests/qruncom.c: Remove libqemu.a example
  tests/Makefile: Remove qruncom target
  qemu-tech.texi: Remove libqemu related stuff from the document
  Makefile.target: Remove libqemu target
  Makefile.objs: Remove libqemu_common.a target
  LICENSE: There is no libqemu.a anymore

 LICENSE         |    4 +-
 Makefile.objs   |  104 --------------------
 Makefile.target |    8 --
 qemu-tech.texi  |    9 --
 tests/Makefile  |    6 -
 tests/qruncom.c |  284 -------------------------------------------------------
 6 files changed, 1 insertions(+), 414 deletions(-)
 delete mode 100644 tests/qruncom.c

-- 
1.7.3.4

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[Markus Armbruster]

Please thread together your patches so that the parts appear as replies
to the cover letter.  git-send-email should do that by default.

Why?  Disconnected parts can easily get separated in the list.  When
that happens, your reviewers need to hunt for parts.  They may choose to
review something else instead.  Can't blame them; reviewing is more
productive than hunting for parts.

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[陳韋任]

> Please thread together your patches so that the parts appear as replies
> to the cover letter.  git-send-email should do that by default.
> 
> Why?  Disconnected parts can easily get separated in the list.  When
> that happens, your reviewers need to hunt for parts.  They may choose to
> review something else instead.  Can't blame them; reviewing is more
> productive than hunting for parts.

  Sorry about that. Should I re-sent this series?

Regards,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[Markus Armbruster]

陳韋任 <chenwj@iis.sinica.edu.tw> writes:

>> Please thread together your patches so that the parts appear as replies
>> to the cover letter.  git-send-email should do that by default.
>> 
>> Why?  Disconnected parts can easily get separated in the list.  When
>> that happens, your reviewers need to hunt for parts.  They may choose to
>> review something else instead.  Can't blame them; reviewing is more
>> productive than hunting for parts.
>
>   Sorry about that. Should I re-sent this series?

Try that if you don't get reviews ;)  Else just get it right with your
next patch series.

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[陳韋任]

On Tue, Nov 08, 2011 at 04:07:12PM +0100, Markus Armbruster wrote:
> 陳韋任 <chenwj@iis.sinica.edu.tw> writes:
> 
> >> Please thread together your patches so that the parts appear as replies
> >> to the cover letter.  git-send-email should do that by default.
> >> 
> >> Why?  Disconnected parts can easily get separated in the list.  When
> >> that happens, your reviewers need to hunt for parts.  They may choose to
> >> review something else instead.  Can't blame them; reviewing is more
> >> productive than hunting for parts.
> >
> >   Sorry about that. Should I re-sent this series?
> 
> Try that if you don't get reviews ;)  Else just get it right with your
> next patch series.

  O.K.. Just want to make sure. What you said "thread together your
patches" has something to do with "sendemail.chainreplyto"? I found
I sent this series one by one, i.e., `git send-email 000#.patch`.
I think I should sent them as a whole, i.e., `git send-email *`. But
I am not sure "sendemail.chainreplyto" matters or not.

  Thanks.  

Regards,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[Max Filippov]

>  O.K.. Just want to make sure. What you said "thread together your
> patches" has something to do with "sendemail.chainreplyto"? I found
> I sent this series one by one, i.e., `git send-email 000#.patch`.
> I think I should sent them as a whole, i.e., `git send-email *`. But
> I am not sure "sendemail.chainreplyto" matters or not.

If you enable sendemail.chainreplyto then each letter in a series
(except the first) will go as a reply to the previous letter.
If you omit sendemail.chainreplyto then letters following the first
one will go as replies to that first letter.

Second option is commonly used and IMHO a bit easier to read than the first.

-- 
Thanks.
-- Max

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[Peter Maydell]

On 8 November 2011 15:16, 陳韋任 <chenwj@iis.sinica.edu.tw> wrote:
>  O.K.. Just want to make sure. What you said "thread together your
> patches" has something to do with "sendemail.chainreplyto"? I found
> I sent this series one by one, i.e., `git send-email 000#.patch`.
> I think I should sent them as a whole, i.e., `git send-email *`. But
> I am not sure "sendemail.chainreplyto" matters or not.

What makes the major difference is sending them all with one
git send-email command. As Max says, not using chainreplyto
is the usual convention, but that's a different thing.

NB that you can say
 git send-email --dry-run *.patch

and it will print out the messages and headers it would have
sent, so you can check that the References headers look like
what you want them to.

PS: personally I like to use git format-patch's "-o directory"
option to write a patch series to its own directory, and then
"git send-email directory" to send; that keeps things separate
and means you won't ever accidentally send some old stale
patch along with your new ones.

-- PMM

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[陳韋任]

> If you enable sendemail.chainreplyto then each letter in a series
> (except the first) will go as a reply to the previous letter.
> If you omit sendemail.chainreplyto then letters following the first
> one will go as replies to that first letter.
> 
> Second option is commonly used and IMHO a bit easier to read than the first.

  I set "chainreplyto = false" in my .gitconfig, then. :)

Regards,
chenwj 

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[Markus Armbruster]

陳韋任 <chenwj@iis.sinica.edu.tw> writes:

> On Tue, Nov 08, 2011 at 04:07:12PM +0100, Markus Armbruster wrote:
>> 陳韋任 <chenwj@iis.sinica.edu.tw> writes:
>> 
>> >> Please thread together your patches so that the parts appear as replies
>> >> to the cover letter.  git-send-email should do that by default.
>> >> 
>> >> Why?  Disconnected parts can easily get separated in the list.  When
>> >> that happens, your reviewers need to hunt for parts.  They may choose to
>> >> review something else instead.  Can't blame them; reviewing is more
>> >> productive than hunting for parts.
>> >
>> >   Sorry about that. Should I re-sent this series?
>> 
>> Try that if you don't get reviews ;)  Else just get it right with your
>> next patch series.
>
>   O.K.. Just want to make sure. What you said "thread together your
> patches" has something to do with "sendemail.chainreplyto"? I found
> I sent this series one by one, i.e., `git send-email 000#.patch`.
> I think I should sent them as a whole, i.e., `git send-email *`. But
> I am not sure "sendemail.chainreplyto" matters or not.

Max already explaind chainreplyto.  I agree with him that chainreplyto
off is preferable.

But what you're after is --thread / sendemail.thread.  See man
git-send-email for details.  The default is --thread, which does the
threading, provided you send all parts at once.

Re: [Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

[陳韋任]

  Thanks, Markus and Peter.

> Max already explaind chainreplyto.  I agree with him that chainreplyto
> off is preferable.
> 
> But what you're after is --thread / sendemail.thread.  See man
> git-send-email for details.  The default is --thread, which does the
> threading, provided you send all parts at once.
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  I'll sent the series at once next time. :)

Regards,
chenwj 

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667