From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:49183) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RNmnI-0003JG-3I for qemu-devel@nongnu.org; Tue, 08 Nov 2011 09:37:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RNmnF-0006X1-KV for qemu-devel@nongnu.org; Tue, 08 Nov 2011 09:36:55 -0500 From: Markus Armbruster Date: Tue, 8 Nov 2011 15:36:49 +0100 Message-Id: <1320763010-10024-3-git-send-email-armbru@redhat.com> In-Reply-To: <1320763010-10024-1-git-send-email-armbru@redhat.com> References: <1320763010-10024-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] x86/cpuid: Plug memory leak in cpudef_setfield() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org To reproduce the leak, put two name options into the same [cpudef] section of target-x86_64.conf. Signed-off-by: Markus Armbruster --- target-i386/cpuid.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/cpuid.c b/target-i386/cpuid.c index 7c8f1be..0fce752 100644 --- a/target-i386/cpuid.c +++ b/target-i386/cpuid.c @@ -969,6 +969,7 @@ static int cpudef_setfield(const char *name, const char *str, void *opaque) int err = 0; if (!strcmp(name, "name")) { + g_free((void *)def->name); def->name = g_strdup(str); } else if (!strcmp(name, "model_id")) { strncpy(def->model_id, str, sizeof (def->model_id)); -- 1.7.6.4