From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org
Subject: [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes
Date: Wed, 9 Nov 2011 17:42:23 +0000 [thread overview]
Message-ID: <1320860543-9596-1-git-send-email-peter.maydell@linaro.org> (raw)
Add missing 'break' statements which would have meant that writing
to an 8 bit NAND device was broken. Spotted by Coverity (see bug
887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
This is an embarrassing bug...
hw/omap_gpmc.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/omap_gpmc.c b/hw/omap_gpmc.c
index 7fc82a2..414f9f5 100644
--- a/hw/omap_gpmc.c
+++ b/hw/omap_gpmc.c
@@ -180,6 +180,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
nand_setio(dev, (value >> 24) & 0xff);
break;
}
+ break;
case OMAP_GPMC_16BIT:
switch (size) {
case 1:
@@ -195,6 +196,7 @@ static void omap_nand_setio(DeviceState *dev, uint64_t value,
nand_setio(dev, (value >> 16) & 0xffff);
break;
}
+ break;
}
}
--
1.7.1
next reply other threads:[~2011-11-09 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 17:42 Peter Maydell [this message]
2011-11-09 19:45 ` [Qemu-devel] [PATCH] hw/omap_gpmc.c: Add missing 'break's to fix 8 bit NAND writes Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320860543-9596-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).